BUG: pd.Series.interpolate non-numeric index column (21662) #25394

TrigonaMinima · 2019-02-21T06:10:16Z

closes pd.Series.interpolate(method="quadratic) Error with non-numeric index column #21662
tests added / passed
passes git diff upstream/master -u -- "*.py" | flake8 --diff

Raises a helpful exception when a non-numeric index is sent to interpolate with methods which require numeric index. Skipped a few methods which can also work on datetime index.

pandas/core/generic.py

mroeschke · 2019-02-21T06:57:51Z

pandas/tests/series/test_missing.py

+            "setting a numeric index column before "\
+            "interpolating."
+        with pytest.raises(ValueError, match=expected_error):
+            result = df[0].interpolate(method="zero")


You can parameterize over method

pandas/tests/series/test_missing.py

pep8speaks · 2019-02-21T14:36:03Z

Hello @TrigonaMinima! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-03-24 19:04:39 UTC

codecov · 2019-02-21T14:36:07Z

Codecov Report

Merging #25394 into master will decrease coverage by 50%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           master   #25394       +/-   ##
===========================================
- Coverage   91.73%   41.72%   -50.01%     
===========================================
  Files         173      173               
  Lines       52845    52848        +3     
===========================================
- Hits        48479    22053    -26426     
- Misses       4366    30795    +26429

Flag	Coverage Δ
#multiple	`?`
#single	`41.72% <0%> (-0.01%)`	⬇️

Impacted Files	Coverage Δ
pandas/core/generic.py	`38.34% <0%> (-55.83%)`	⬇️
pandas/io/formats/latex.py	`0% <0%> (-100%)`	⬇️
pandas/core/categorical.py	`0% <0%> (-100%)`	⬇️
pandas/io/sas/sas_constants.py	`0% <0%> (-100%)`	⬇️
pandas/tseries/plotting.py	`0% <0%> (-100%)`	⬇️
pandas/tseries/converter.py	`0% <0%> (-100%)`	⬇️
pandas/io/formats/html.py	`0% <0%> (-99.35%)`	⬇️
pandas/core/groupby/categorical.py	`0% <0%> (-95.46%)`	⬇️
pandas/io/sas/sas7bdat.py	`0% <0%> (-91.17%)`	⬇️
pandas/io/sas/sas_xport.py	`0% <0%> (-90.15%)`	⬇️
... and 131 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c0f6a8...f62894b. Read the comment docs.

codecov · 2019-02-21T14:36:07Z

Codecov Report

Merging #25394 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #25394      +/-   ##
==========================================
+ Coverage   91.47%   91.47%   +<.01%     
==========================================
  Files         173      173              
  Lines       52872    52876       +4     
==========================================
+ Hits        48364    48368       +4     
  Misses       4508     4508

Flag	Coverage Δ
#multiple	`90.03% <100%> (ø)`	⬆️
#single	`41.82% <16.66%> (-0.01%)`	⬇️

Impacted Files	Coverage Δ
pandas/core/generic.py	`93.54% <100%> (+0.01%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2618b21...d227f8a. Read the comment docs.

pandas/tests/series/test_missing.py

pandas/core/generic.py

jreback · 2019-02-21T20:23:50Z

pandas/tests/series/test_missing.py

+        "method",
+        {
+            "linear", "zero", "slinear", "quadratic", "cubic", "spline",
+            "barycentric", "polynomial", "krogh", "piecewise_polynomial",


we might have a fixture for this

pandas/tests/series/test_missing.py

TrigonaMinima · 2019-03-12T18:01:31Z

@jreback this PR is complete. I have rebased it with the master as well. The unsuccessful checks are because of the previous commits.

jreback · 2019-03-20T01:36:51Z

can you merge master

jreback · 2019-03-22T11:23:15Z

pandas/core/generic.py

@@ -6863,6 +6863,18 @@ def interpolate(self, method='linear', axis=0, limit=None, inplace=False,
            index = np.arange(len(_maybe_transposed_self._get_axis(alt_ax)))
        else:
            index = _maybe_transposed_self._get_axis(alt_ax)
+            methods = {"index", "values", "nearest", "time"}
+            num_dt_flg = (


call is this: is_numeric_or_datetime

jreback · 2019-03-22T11:23:43Z

pandas/tests/series/test_missing.py

@@ -14,6 +14,8 @@
 from pandas.errors import PerformanceWarning
 import pandas.util._test_decorators as td

+from pandas.core.dtypes.common import is_timedelta64_dtype


in tests we want to import from: pandas.api.types

jreback · 2019-03-22T11:25:38Z

pandas/tests/series/test_missing.py

+        if method == "pchip":
+            _skip_if_no_pchip()
+        elif is_timedelta64_dtype(ind):
+            if method in {"linear", "index", "values", "pchip"}:


i find this a touch complicated. it might be worthile to make this into several tests (you would make a fixture for the input parameterization)

jreback · 2019-03-22T11:26:27Z

can you add a whatsnew note as well (bug fixes / numeric)

TrigonaMinima · 2019-03-22T13:22:40Z

@jreback done

jreback

looks good. small change. ping on green.

jreback · 2019-03-23T20:27:12Z

pandas/core/generic.py

+                    "Index column must be numeric or datetime type when "
+                    "using any interpolation method other than linear. "
+                    "Try setting a numeric or datetome index column before "
+                    "interpolating.")


you can add that {method} was passed in the text.

use a replacement, e.g. "{method}"....format(method=method)

TrigonaMinima · 2019-03-24T11:30:25Z

@jreback it's green now

jreback · 2019-03-24T15:30:43Z

pandas/core/generic.py

+                    "Index column must be numeric or datetime type when "
+                    "using any interpolation method other than linear. "
+                    "Try setting a numeric or datetome index column before "
+                    "interpolating.")


use a replacement, e.g. "{method}"....format(method=method)

jreback · 2019-03-24T23:34:07Z

thanks @TrigonaMinima

mroeschke reviewed Feb 21, 2019

View reviewed changes

pandas/core/generic.py Outdated Show resolved Hide resolved

mroeschke reviewed Feb 21, 2019

View reviewed changes

pandas/core/generic.py Outdated Show resolved Hide resolved

mroeschke reviewed Feb 21, 2019

View reviewed changes

pandas/tests/series/test_missing.py Outdated Show resolved Hide resolved

mroeschke added Error Reporting Incorrect or improved errors from pandas Numeric Operations Arithmetic, Comparison, and Logical operations labels Feb 21, 2019

mroeschke reviewed Feb 21, 2019

View reviewed changes

pandas/tests/series/test_missing.py Outdated Show resolved Hide resolved

jreback requested changes Feb 21, 2019

View reviewed changes

TrigonaMinima commented Feb 23, 2019

View reviewed changes

pandas/tests/series/test_missing.py Show resolved Hide resolved

jreback requested changes Mar 22, 2019

View reviewed changes

jreback requested changes Mar 23, 2019

View reviewed changes

jreback added this to the 0.25.0 milestone Mar 23, 2019

jreback requested changes Mar 24, 2019

View reviewed changes

BUG: pd.Series.interpolate non-numeric index column (21662)

d227f8a

jreback approved these changes Mar 24, 2019

View reviewed changes

jreback merged commit 9821b77 into pandas-dev:master Mar 24, 2019

TrigonaMinima deleted the interpolate_quad branch March 25, 2019 01:59

alorenzo175 mentioned this pull request Jul 23, 2019

pd.Series.interpolate() ValueError for some methods with TZ localized index #27548

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BUG: pd.Series.interpolate non-numeric index column (21662) #25394

BUG: pd.Series.interpolate non-numeric index column (21662) #25394

TrigonaMinima commented Feb 21, 2019

mroeschke Feb 21, 2019

pep8speaks commented Feb 21, 2019 •

edited

Loading

codecov bot commented Feb 21, 2019

codecov bot commented Feb 21, 2019 •

edited

Loading

jreback Feb 21, 2019

TrigonaMinima commented Mar 12, 2019

jreback commented Mar 20, 2019

jreback Mar 22, 2019

jreback Mar 22, 2019

jreback Mar 22, 2019

jreback commented Mar 22, 2019

TrigonaMinima commented Mar 22, 2019

jreback left a comment

jreback Mar 23, 2019

jreback Mar 24, 2019

TrigonaMinima Mar 24, 2019

TrigonaMinima commented Mar 24, 2019

jreback Mar 24, 2019

jreback commented Mar 24, 2019

BUG: pd.Series.interpolate non-numeric index column (21662) #25394

BUG: pd.Series.interpolate non-numeric index column (21662) #25394

Conversation

TrigonaMinima commented Feb 21, 2019

Choose a reason for hiding this comment

pep8speaks commented Feb 21, 2019 • edited Loading

Comment last updated at 2019-03-24 19:04:39 UTC

codecov bot commented Feb 21, 2019

Codecov Report

codecov bot commented Feb 21, 2019 • edited Loading

Codecov Report

Choose a reason for hiding this comment

TrigonaMinima commented Mar 12, 2019

jreback commented Mar 20, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jreback commented Mar 22, 2019

TrigonaMinima commented Mar 22, 2019

jreback left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TrigonaMinima commented Mar 24, 2019

Choose a reason for hiding this comment

jreback commented Mar 24, 2019

pep8speaks commented Feb 21, 2019 •

edited

Loading

codecov bot commented Feb 21, 2019 •

edited

Loading