Skip to content

Specify build requirements in pyproject.toml (PEP 517) #25227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
1 change: 1 addition & 0 deletions MANIFEST.in
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ include LICENSE
include RELEASE.md
include README.md
include setup.py
include pyproject.toml

graft doc
prune doc/build
Expand Down
3 changes: 2 additions & 1 deletion doc/source/whatsnew/v0.25.0.rst
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,7 @@ Reshaping
- Bug in :func:`pandas.cut` where large bins could incorrectly raise an error due to an integer overflow (:issue:`26045`)
- Bug in :func:`DataFrame.sort_index` where an error is thrown when a multi-indexed DataFrame is sorted on all levels with the initial level sorted last (:issue:`26053`)
- Bug in :meth:`Series.nlargest` treats ``True`` as smaller than ``False`` (:issue:`26154`)
- Bug in :func:`factorize` when passing an ``ExtensionArray`` with a custom ``na_sentinel`` (:issue:`25696`).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some merge left-overs?


Sparse
^^^^^^
Expand All @@ -435,8 +436,8 @@ Sparse
Other
^^^^^

- Specify build-time requirement in ``pyproject.toml`` (:issue:`25193`)
- Removed unused C functions from vendored UltraJSON implementation (:issue:`26198`)
- Bug in :func:`factorize` when passing an ``ExtensionArray`` with a custom ``na_sentinel`` (:issue:`25696`).
- Allow :class:`Index` and :class:`RangeIndex` to be passed to numpy ``min`` and ``max`` functions.


Expand Down
9 changes: 9 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# When changing the version numbers here, also adjust them in `setup.py`
[build-system]
requires = [
"setuptools",
"wheel",
"Cython >= 0.28.2", # required for VCS build, optional for released source
"numpy==1.13.3; python_version<'3.7'",
"numpy==1.14.5; python_version>='3.7'",
]
11 changes: 7 additions & 4 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,17 @@ def is_platform_mac():
return sys.platform == 'darwin'


min_numpy_ver = '1.13.3'
# When changing the version numbers here, also adjust them in `pyproject.toml`
numpy_requires = [
"numpy>=1.13.3; python_version<'3.7'",
"numpy>=1.14; python_version>='3.7'",
]
setuptools_kwargs = {
'install_requires': [
'python-dateutil >= 2.5.0',
'pytz >= 2015.4',
'numpy >= {numpy_ver}'.format(numpy_ver=min_numpy_ver),
],
'setup_requires': ['numpy >= {numpy_ver}'.format(numpy_ver=min_numpy_ver)],
] + numpy_requires,
'setup_requires': numpy_requires,
'zip_safe': False,
}

Expand Down