BUG: fix sorting with observed=True in groupby #25173
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
commented
Feb 5, 2019
| @@ -269,7 +269,7 @@ def test_groupby_categorical_index_and_columns(self, observed): | |||
| # if we are not-observed we undergo a reindex | |||
| # so need to adjust the output as our expected sets us up | |||
| # to be non-observed | |||
| expected_columns = CategoricalIndex(['A', 'B'], | |||
| expected_columns = CategoricalIndex(['B', 'A'], | |||
There was a problem hiding this comment.
expected_columns should have ['B', 'A'], because ordered=True.
Codecov Report
@@ Coverage Diff @@
## master #25173 +/- ##
==========================================
+ Coverage 92.37% 92.37% +<.01%
==========================================
Files 166 166
Lines 52408 52409 +1
==========================================
+ Hits 48412 48413 +1
Misses 3996 3996
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #25173 +/- ##
==========================================
+ Coverage 92.37% 92.37% +<.01%
==========================================
Files 166 166
Lines 52408 52409 +1
==========================================
+ Hits 48412 48413 +1
Misses 3996 3996
Continue to review full report at Codecov.
|
jreback
requested changes
Feb 6, 2019
| @@ -360,6 +360,14 @@ def test_observed(observed): | |||
| expected = groups2.agg('mean').reset_index() | |||
| tm.assert_frame_equal(result, expected) | |||
|
|
|||
| # GH 25167 | |||
There was a problem hiding this comment.
make this a separate test, parameterize by sort as well
jreback
requested changes
Mar 3, 2019
| @@ -73,7 +73,7 @@ Bug Fixes | |||
|
|
|||
| **Reshaping** | |||
|
|
|||
| - | |||
| - Fixed bug in :meth:`DataFrame.groupby` where using ``observed=True`` didn't sort properly (:issue:`25167`) | |||
|
Closing as stale ping if you'd like to continue |
kpflugshaupt
added a commit
to kpflugshaupt/pandas
that referenced
this pull request
Mar 26, 2019
As documented in pandas-dev#25871, groupby() on an ordered Categorical messes up category order when 'observed=True' is specified. Specifically, group labels will be ordered by first occurrence (as for an unordered Categorical), but grouped aggregation results will retain the Categorical's order. The fix is a modified subset of pandas-dev#25173, which fixes a related case, but has not been merged yet.
4 tasks
kpflugshaupt
added a commit
to kpflugshaupt/pandas
that referenced
this pull request
Mar 28, 2019
* BUG: Fix groupby on ordered Categoricals (GH25871) As documented in pandas-dev#25871, groupby() on an ordered Categorical messes up category order when 'observed=True' is specified. Specifically, group labels will be ordered by first occurrence (as for an unordered Categorical), but grouped aggregation results will retain the Categorical's order. The fix is a modified subset of pandas-dev#25173, which fixes a related case, but has not been merged yet. * BUG: Fix groupby on ordered Categoricals (GH25871) * new test * Fix groupby on ordered Categoricals (GH25871) Testing all combinations of: - ordered vs. unordered grouping column - 'observed' True vs. False - 'sort' True vs. False In all cases, result group ordering must be correct. The test is built such that the result index labels are equal to aggregation results if all goes well (except for the one unobserved category)
4 tasks
kpflugshaupt
added a commit
to kpflugshaupt/pandas
that referenced
this pull request
Mar 28, 2019
* BUG: Fix groupby sorting on ordered Categoricals (GH25871) (#1) * BUG: Fix groupby on ordered Categoricals (GH25871) As documented in pandas-dev#25871, groupby() on an ordered Categorical messes up category order when 'observed=True' is specified. Specifically, group labels will be ordered by first occurrence (as for an unordered Categorical), but grouped aggregation results will retain the Categorical's order. The fix is a modified subset of pandas-dev#25173, which fixes a related case, but has not been merged yet. * BUG: Fix groupby on ordered Categoricals (GH25871) * new test * Fix groupby on ordered Categoricals (GH25871) Testing all combinations of: - ordered vs. unordered grouping column - 'observed' True vs. False - 'sort' True vs. False In all cases, result group ordering must be correct. The test is built such that the result index labels are equal to aggregation results if all goes well (except for the one unobserved category) * Revert "BUG: Fix groupby sorting on ordered Categoricals (GH25871) (#1)" This reverts commit b265349.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffFix bug in #25167.