-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
validate_docstrings improvements #25122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validate_docstrings improvements #25122
Conversation
Thanks for the PR.
|
Codecov Report
@@ Coverage Diff @@
## master #25122 +/- ##
==========================================
+ Coverage 92.37% 92.37% +<.01%
==========================================
Files 166 166
Lines 52415 52415
==========================================
+ Hits 48418 48419 +1
+ Misses 3997 3996 -1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #25122 +/- ##
==========================================
+ Coverage 92.37% 92.37% +<.01%
==========================================
Files 166 166
Lines 52415 52415
==========================================
+ Hits 48418 48419 +1
+ Misses 3997 3996 -1
Continue to review full report at Codecov.
|
I would avoid all these changes based on personal preference. It just adds noise to keep changing tabs by spaces in the output, or adding line breaks to function calls. The code is respecting PEP8, and if every person reformats based on his personal preference, we'll change those at every PR. Can you revert those, leave the relevant part of the PR, and fix the problems in the CI please? |
Closing for now due to failures and comments above. If you want to pursue further please open an issue first for discussion |
Some minor improvments to
validate_docstrings
:--list-errors
flag to list error codes / descriptions