-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: fix timestamp timedelta quotes #25118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jreback
merged 20 commits into
pandas-dev:master
from
dcreekp:doc-fix-timestamp-timedelta-quotes
Mar 30, 2019
Merged
Changes from 18 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
dc0b8c3
TST: clean up to change setup.cfg to `xfail_strict = True` (GH23057)
2bac2c6
TST: clean up to change setup.cfg to `xfail_strict = True` edit (GH23…
f645380
TST: clean up to change setup.cfg to `xfail_strict = True` edit2 (GH2…
b0b23b9
TST: remove redundant `strict=True` parameter (GH23057)
e2261f9
Merge branch 'master' of github.com:pandas-dev/pandas
ac0003f
Merge branch 'master' of github.com:pandas-dev/pandas
a02a7b4
Merge remote-tracking branch 'upstream/master'
bd97e5e
Merge remote-tracking branch 'upstream/master'
6e2fb3a
Merge branch 'master' of https://github.com/pandas-dev/pandas
099cd57
Merge branch 'master' of https://github.com/pandas-dev/pandas
7815ef0
DOC: Reposition quotes in pandas.Timestamp and pandas.Timedelta #24070
bc1fb28
DOC: edit nattype.pyx to match changes in timedeltas.pyx
2aec3e1
DOC: make timedeltas.pyx to_pytimedelta an actual docstring
b84ef90
DOC: small edits to pandas.Timestamp docstring
c09d83a
DOC: consolidate pandas.Timedelta.to_pytimedelta docstring
27c97d1
DOC: corrections to timedeltas.pyx docstrings
fd0de80
DOC: adjust indentation of docstring example
6349040
DOC: another correction
5cb7828
DOC: correct pandas.Timestamp.to_datetime64
549633d
DOC: delete examples for pandas.Timedelta.to_pytimedelta
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure i would add all of these examples, 1 example at most and it should actually use this function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jreback
I've made these changes: c09d83a
If there's anything else, please let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these doctests pass? It looks like the whitespace formatting is off.
You may need to add a
doctest: +NORMALIZE_WHITESPACE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think any of these examples are needed, they are not showing this internal rountine. I would simply remove them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dcreekp as I said above I would remove all of these examples