Skip to content

## DO NOT MERGE. BUG: Fix .dropna() functionality for categorical indices #25091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

## DO NOT MERGE. BUG: Fix .dropna() functionality for categorical indices #25091

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e1d3b66
Merge pull request #2 from pandas-dev/master
rs2 Aug 30, 2017
90ec575
Merge branch 'master' of https://github.com/pandas-dev/pandas
rs2 Oct 4, 2017
66aefc1
Merge pull request #3 from pandas-dev/master
rs2 Nov 14, 2017
c07adbd
Merge pull request #4 from pandas-dev/master
rs2 Sep 22, 2018
89d8289
Merge pull request #5 from pandas-dev/master
rs2 Feb 2, 2019
09a9f80
#25087: Fix .dropna() functionality for categorical indices
rs2 Feb 2, 2019
e0c720d
#25087: Favor .loc instead of _take
rs2 Feb 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/core/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4615,7 +4615,7 @@ def dropna(self, axis=0, how='any', thresh=None, subset=None,
else:
raise TypeError('must specify how or thresh')

result = self.loc(axis=axis)[mask]
result = self.loc(axis=axis)[mask.to_numpy()]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not need the alignment from the index anymore?

Copy link
Contributor Author

@rs2 rs2 Feb 2, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomAugspurger It turned out to be a bit wider issue. Kudos to @jorisvandenbossche for an insightful discussion. The behavior of an_index[mask], 'foo' in an_index, an_index.get_loc(mask) is currently inconsistent across various index types, in particular, Categorical(pd.interval_range(0.1, 3.14)), Categorical(pd.interval_range(1, 2)).

Does this require a separate issue, or I could just post repro snippets and outcomes as of 0.23.4 and 0.24.0 into #25087?


if inplace:
self._update_inplace(result)
Expand Down