Skip to content

Fixes Formatting Exception #25088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 16, 2019
6 changes: 3 additions & 3 deletions doc/source/whatsnew/v0.24.2.rst
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ Bug Fixes

**I/O**

-
- Fixed an output formatting exception in pandas/io/formats/terminal.py;
-
-

Expand Down Expand Up @@ -95,5 +95,5 @@ Bug Fixes

Contributors
~~~~~~~~~~~~

.. contributors:: v0.24.1..v0.24.2
EternalLearner42
.. contributors:: v0.24.1..v0.24.2
16 changes: 9 additions & 7 deletions pandas/io/formats/terminal.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

import os
import shutil

import subprocess
from pandas.compat import PY3

__all__ = ['get_terminal_size', 'is_terminal']
Expand Down Expand Up @@ -95,20 +95,22 @@ def _get_terminal_size_tput():
# src: http://stackoverflow.com/questions/263890/how-do-i-find-the-width
# -height-of-a-terminal-window
try:
import subprocess
proc = subprocess.Popen(["tput", "cols"],
stdin=subprocess.PIPE,
stdout=subprocess.PIPE)
output = proc.communicate(input=None)
cols = int(output[0])
output_cols = proc.communicate(input=None)
proc = subprocess.Popen(["tput", "lines"],
stdin=subprocess.PIPE,
stdout=subprocess.PIPE)
output = proc.communicate(input=None)
rows = int(output[0])
return (cols, rows)
output_rows = proc.communicate(input=None)
except OSError:
return None
try:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a blank line & a comment here on what you are doing

cols = int(output_cols[0])
rows = int(output_rows[0])
return (cols, rows)
except ValueError:
return None


def _get_terminal_size_linux():
Expand Down