BUG: Index Name is not displayed with header=False in to_csv #24840

charlesdong1991 · 2019-01-19T20:37:33Z

xref (row) Index Name is not displayed with header=False master tracker #24546
tests added / passed
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

codecov · 2019-01-19T21:03:59Z

Codecov Report

Merging #24840 into master will decrease coverage by 49.47%.
The diff coverage is 50%.

@@             Coverage Diff             @@
##           master   #24840       +/-   ##
===========================================
- Coverage   92.38%   42.91%   -49.48%     
===========================================
  Files         166      166               
  Lines       52382    52390        +8     
===========================================
- Hits        48395    22482    -25913     
- Misses       3987    29908    +25921

Flag	Coverage Δ
#multiple	`?`
#single	`42.91% <50%> (ø)`	⬆️

Impacted Files	Coverage Δ
pandas/io/formats/csvs.py	`68.36% <50%> (-29.87%)`	⬇️
pandas/io/formats/latex.py	`0% <0%> (-100%)`	⬇️
pandas/core/categorical.py	`0% <0%> (-100%)`	⬇️
pandas/io/sas/sas_constants.py	`0% <0%> (-100%)`	⬇️
pandas/tseries/plotting.py	`0% <0%> (-100%)`	⬇️
pandas/tseries/converter.py	`0% <0%> (-100%)`	⬇️
pandas/io/formats/html.py	`0% <0%> (-99.35%)`	⬇️
pandas/core/groupby/categorical.py	`0% <0%> (-95.46%)`	⬇️
pandas/io/sas/sas7bdat.py	`0% <0%> (-91.17%)`	⬇️
pandas/io/sas/sas_xport.py	`0% <0%> (-90.15%)`	⬇️
... and 124 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa05e54...3941906. Read the comment docs.

codecov · 2019-01-19T21:03:59Z

Codecov Report

Merging #24840 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #24840      +/-   ##
==========================================
+ Coverage   91.47%   91.47%   +<.01%     
==========================================
  Files         172      173       +1     
  Lines       52870    52882      +12     
==========================================
+ Hits        48362    48376      +14     
+ Misses       4508     4506       -2

Flag	Coverage Δ
#multiple	`90.04% <100%> (ø)`	⬆️
#single	`41.82% <46.87%> (ø)`	⬆️

Impacted Files	Coverage Δ
pandas/core/generic.py	`93.52% <ø> (ø)`	⬆️
pandas/io/formats/csvs.py	`98.36% <100%> (+0.13%)`	⬆️
pandas/io/pytables.py	`90.19% <0%> (-0.01%)`	⬇️
pandas/io/formats/format.py	`97.99% <0%> (ø)`	⬆️
pandas/core/indexes/interval.py	`95.25% <0%> (ø)`	⬆️
pandas/core/indexes/multi.py	`95.62% <0%> (ø)`	⬆️
pandas/plotting/_core.py	`83.65% <0%> (ø)`	⬆️
pandas/io/formats/printing.py	`85.34% <0%> (ø)`	⬆️
pandas/core/api.py	`100% <0%> (ø)`	⬆️
pandas/core/computation/expressions.py	`93.27% <0%> (ø)`	⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f5a7e3...3dc0027. Read the comment docs.

jreback

comments & failing the CI.

jreback · 2019-01-19T21:43:37Z

pandas/io/formats/csvs.py

@@ -188,6 +188,35 @@ def save(self):
                for _fh in handles:
                    _fh.close()

+    def _index_label_encoder(self):


can you add a doc-string

jreback · 2019-01-19T21:43:46Z

pandas/io/formats/csvs.py

+            if index_label is None:
+                if isinstance(obj.index, ABCMultiIndex):
+                    index_label = []
+                    for i, name in enumerate(obj.index.names):


add comments where appropriate

jreback · 2019-01-19T21:43:55Z

pandas/io/formats/csvs.py

@@ -201,6 +230,9 @@ def _save_header(self):
        has_aliases = isinstance(header, (tuple, list, np.ndarray,
                                          ABCIndexClass))
        if not (has_aliases or self.header):
+            encoded_labels = self._index_label_encoder()


can you add a comment here

jreback · 2019-01-19T21:45:31Z

@simonjayhawkins if you'd have a look

charlesdong1991 · 2019-01-19T22:47:43Z

oh... yeah... output will look different after to_csv... need to fix other pytest errors in read_csv and maybe read_csv function as well... will look into it... thanks for the quick feedback!

simonjayhawkins · 2019-01-19T22:51:55Z

@charlesdong1991 can you change closes #24546 to xref #24546, other output formatting methods need to be checked before the issue is closed. thanks.

simonjayhawkins · 2019-01-19T23:09:41Z

to_csv is using CSVFormatter and does not have an index_names parameter like the DataFrameFormatter class. is it possible to retain the existing behavior of displaying the index without the index names without a change to the api?

gfyoung · 2019-01-19T23:26:30Z

to_csv is using CSVFormatter and does not have an index_names parameter like the DataFrameFormatter class. is it possible to retain the existing behavior of displaying the index without the index names without a change to the api?

@simonjayhawkins : I'm personally not too concerned if we have to add this parameter to the class. It's not very visible (if at all) from a general pandas API perspective.

gfyoung · 2019-01-19T23:29:45Z

oh... yeah... output will look different after to_csv... need to fix other pytest errors in read_csv and maybe read_csv function as well... will look into it... thanks for the quick feedback!

@charlesdong1991 : I strongly suspect that you will not have to modify anything in read_csv at this point. If there are round-trip issues that you observe, let's tackle in a separate PR.

gfyoung · 2019-01-19T23:30:38Z

pandas/tests/generic/test_frame.py

+        (False, 'index.name,,\n0,0,0\n1,0,0\n'),
+        (True, 'index.name,0,1\n0,0,0\n1,0,0\n')
+    ])
+    def test_to_csv_header_not_multi_index(self, header, expected):


Instead of "not_multi_index," just call it "single_index"

You could potentially even squash your tests together so that in your parameterization, you pass in the index that you want to set on df.index.

Not sure if that makes parameterization a little more complicated, but that's also another thought, given how similar how some of the code is between both of your tests.

yeah, thanks for the review! @gfyoung i thought about it, but i thought they represented two different cases although the ultimate idea is to test if index name is displayed or not... so i separated them... but i will try to squash them a bit and see if it makes tests clearer.

simonjayhawkins · 2019-01-19T23:40:07Z

I'm personally not too concerned if we have to add this parameter to the class. It's not very visible (if at all) from a general pandas API perspective

@gfyoung if a parameter is added to CSVFormatter it would also need to be added to to_csv?

simonjayhawkins · 2019-01-19T23:49:14Z

pandas/io/formats/csvs.py

@@ -188,6 +188,35 @@ def save(self):
                for _fh in handles:
                    _fh.close()

+    def _index_label_encoder(self):


there is _get_column_name_list in format.py, could this be moved into a base class/mixin and reused?

pandas/pandas/io/formats/format.py

Lines 840 to 848 in f57bd72

def _get_column_name_list(self):

names = []

columns = self.frame.columns

if isinstance(columns, ABCMultiIndex):

names.extend('' if name is None else name

for name in columns.names)

else:

names.append('' if columns.name is None else columns.name)

return names

Potentially. Let's revisit once tests are passing again.

future PR though.

gfyoung · 2019-01-19T23:54:55Z

@simonjayhawkins : Eventually, we should, but for now, we can keep the parameter internal (so as to fix the bug) to CSVFormatter. Changing the API wouldn't be ideal since we are in the middle of an RC cycle, unless we want to delay this until the next major release (or maybe next minor one)..

However, I see no reason to not patch the bug now and then expose index_names later.

jreback · 2019-01-20T16:11:43Z

pandas/core/generic.py

@@ -2916,6 +2916,8 @@ def to_csv(self, path_or_buf=None, sep=",", na_rep='', float_format=None,
            sequence should be given if the object uses MultiIndex. If
            False do not print fields for index names. Use index_label=False
            for easier importing in R.
+        index_name: bool, default True.


what is the purpose of this? we already have the index and index_label?

After collecting feedbacks from @gfyoung and @simonjayhawkins, if i understand correctly, a parameter index_name could be added into CSVFormatter that determines if index name should be kept/displayed or not if it is not None, since header in to_csv should only removes columns names based on its definition.

this is what index_label already does

pep8speaks · 2019-01-20T16:46:49Z

Hello @charlesdong1991! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-03-24 22:25:00 UTC

simonjayhawkins · 2019-01-21T11:42:57Z

pandas/tests/frame/test_to_csv.py

@@ -764,7 +765,7 @@ def test_to_csv_wide_frame_formatting(self):
        # Issue #8621
        df = DataFrame(np.random.randn(1, 100010), columns=None, index=None)
        with ensure_clean() as filename:
-            df.to_csv(filename, header=False, index=False)
+            df.to_csv(filename, header=False, index=False, index_label=False)


the default for index_label is None, but it probably makes sense for the default to be False when header=False. This would maintain backwards compatibility and follow the Principle of Least Astonishment.

you are right!!! thanks for the review and feedback! @simonjayhawkins just changed!

you will also need to change the docstring. to make it less wordy. it may be worth allowing True as an option, having True as the default when header and index are True and then the current default None will just become the new default. i.e. True use the column and index names if they exist and so maintain backwards compatibility.

thanks for the feedback, I am not sure if this is worth it... since when header and index are True, then current default None plays exactly same role as True, which will print index name is it exists, so the users don't have to define it. And I haven't found other use cases for index_label being True. Please enlighten me if you have different thoughts. @simonjayhawkins

jreback · 2019-01-21T13:29:20Z

pandas/io/formats/csvs.py

-                 decimal='.'):
+                 index_label=None, mode='w', nanRep=None,
+                 encoding=None, compression='infer', quoting=None,
+                 line_terminator='\n', chunksize=None, tupleize_cols=False,


if you don't need to change these, pls revert

jreback · 2019-01-21T13:29:32Z

pandas/core/generic.py

            Column label for index column(s) if desired. If None is given, and
-            `header` and `index` are True, then the index names are used. A
+            `header` and `index` are True, then the index names are used. If
+            `header` is False or None, default index_label changes to False,


this is really odd to do

Thanks for the review, @jreback ! Can you say more about it? The change now is because, in previous api design, when header is set to None or False, col names and index names will be all gone (won't be printed), and in this new change, the index name and col names are separated, and default index_label is None which means index names will still be printed if they exist. Therefore, following @simonjayhawkins suggestion to maintain backwards compatibility, in our internal CSVFormatter, the index_label will be changed to False given header is None or False. And I am glad to hear more feedbacks!

sorry if i was not clear..

i was think along the lines

index_label : str or sequence, or bool, default { True, False if header or index are False

this should result in an non breaking api and maintain the same behaviour for None which does not need to be included in the docstring

thanks! i just changed and removed None! @simonjayhawkins

oh, wait!! would this still not be able to display index names when header=False since index_label is coerced to False by default? @simonjayhawkins

if its explicitly set to True by the caller then the default values become irrelevant.

charlesdong1991 · 2019-01-21T17:30:32Z

Thanks a lot for all of your reviews! I think this time all should work!
I changed the design a bit so in this PR:

The default is still None, and if index_label is not explicitly called, then index_label is set to False by default if either header or index is False; otherwise, index_label is True by default.
If index_label is explicitly called, then index_label will be given following the caller.

Benefits:

Fix the bug.
Adding flexibility and separating col names and index names correctly.
Maintain the backward compatibility and no need to change API for now.

I am looking forward to your feedbacks! @jreback @simonjayhawkins @gfyoung

simonjayhawkins · 2019-01-21T17:52:48Z

pandas/tests/generic/test_frame.py

@@ -269,3 +270,40 @@ def test_deepcopy_empty(self):
        empty_frame_copy = deepcopy(empty_frame)

        self._compare(empty_frame_copy, empty_frame)
+
+    @pytest.mark.skipif(os.name == 'nt',


if you use tm.convert_rows_list_to_csv_str this should become unnecessary.

oh, yeah! nice!

simonjayhawkins · 2019-01-21T17:52:59Z

pandas/tests/generic/test_frame.py

+        (False, None, '0,0,0\n1,0,0\n'),
+        (True, None, 'index.name,0,1\n0,0,0\n1,0,0\n')
+    ])
+    def test_to_csv_header_single_index(self, header, index_label, expected):


the tests should probably go in pandas\tests\io\formats\test_to_csv.py

simonjayhawkins · 2019-01-21T17:56:53Z

pandas/tests/generic/test_frame.py

+    def test_to_csv_header_single_index(self, header, index_label, expected):
+        # issue 24546
+        df = pd.DataFrame(np.zeros((2, 2), dtype=int))
+        df.index.name = 'index.name'


for added assurance it may be worth also assigning a name (different to the row index name) to the columns index in the test set-up

i was thinking df.columns.name here.

simonjayhawkins · 2019-01-21T18:34:46Z

pandas/tests/frame/test_to_csv.py

@@ -120,6 +120,7 @@ def test_to_csv_from_csv3(self):

            df1.to_csv(path)
            df2.to_csv(path, mode='a', header=False)
+


you'll need to revert changes to this module.

WillAyd · 2019-02-28T00:10:53Z

@charlesdong1991 can you merge master?

charlesdong1991 · 2019-02-28T20:26:38Z

Thanks @WillAyd , i just merged to master.

WillAyd · 2019-03-01T00:15:12Z

pandas/io/formats/csvs.py

+        # if index label is not explicitly called, index label is True if
+        # header or index is not False; otherwise, index label is set to False
+        if index_label is None:
+            if self.header is False or self.header is None or not self.index:


Suggested change

if self.header is False or self.header is None or not self.index:

if not (self.header or self.index):

yeah... thanks @WillAyd ... however, it doesn't seem equal in my test. Because by default, self.index is True, and with if not (self.header or self.index), the result will be always False if self.index uses default value, and it doesn't align to my purpose.

So not self.header or not self.index then?

can you update this

self.index_label = self.header or self.index

seems equivalent

it does seem equivalent though,

header : bool or list of str, default True Write out the column names. If a list of strings is given it is assumed to be aliases for the column names. .. versionchanged:: 0.24.0

for instance, since from version 0.24.0, it looks like header could be a list, and if a list is given, we don't want to assign this list to index_label

try bool(self.header) or self.index then

WillAyd · 2019-03-01T00:15:40Z

pandas/io/formats/csvs.py

+    def _index_label_encoder(self):
+        """Encode index label if it is not False.
+
+        Returns:


Can you conform docstring to the pandas standard?

thanks, changed! and i also add several more tests! @WillAyd

WillAyd · 2019-03-01T00:16:30Z

pandas/io/formats/csvs.py

+            # append index label based on index type
+            if isinstance(obj.index, ABCMultiIndex):
+                index_label = []
+                for i, name in enumerate(obj.index.names):


What's the use of enumerate here?

thanks, changed!

WillAyd · 2019-03-01T00:22:30Z

pandas/io/formats/csvs.py

+                    index_label = ['']
+                else:
+                    index_label = [index_label]
+        elif not isinstance(index_label,


When does the code go down this branch?

sorry, should be if index_label is True above. @WillAyd

charlesdong1991 · 2019-03-01T14:24:58Z

I pushed some changes based on your nice reviews, @WillAyd looks like there was a connection issue during checking, i will re-push it along with fixes of your potential follow-up change requests :)

WillAyd · 2019-03-01T17:52:48Z

pandas/io/formats/csvs.py

+        # if index label is not explicitly called, index label is True if
+        # header or index is not False; otherwise, index label is set to False
+        if index_label is None:
+            if self.header is False or self.header is None or not self.index:


So not self.header or not self.index then?

WillAyd · 2019-03-01T17:55:25Z

pandas/io/formats/csvs.py

+        if index_label is True:
+            # append index label based on index type
+            if isinstance(obj.index, ABCMultiIndex):
+                index_label = []


There's generally a lot of shadowing of index_label here that I think can only cause confusion. Given this always needs to be a list on return, why not just insatiate to an empty list and then append the appropriate value within each branch?

i simplified a bit, would like to hear your opinion. @WillAyd

WillAyd · 2019-03-01T17:55:50Z

pandas/io/formats/csvs.py

-            return
+        if not (has_aliases or header):
+            # if index_label is False, nothing will display.
+            if index_label is False:


Does it matter if this is None?

it depends, if index label is not explicitly called which is None, index label is True if header or index is not False; otherwise, index label is set to False

WillAyd · 2019-03-19T03:50:10Z

@charlesdong1991 can you check failures, merge master and address comments?

FYI if you merge master you shouldn't need a force push, which is preferable for maintaining GH comment history

charlesdong1991 · 2019-03-24T15:34:00Z

Hi, @WillAyd last time it was failed because of master failure, and I just merged the master, and see if the tests can be passed.

pandas/core/generic.py

jreback · 2019-03-24T18:36:00Z

pandas/io/formats/csvs.py

@@ -50,7 +50,17 @@ def __init__(self, obj, path_or_buf=None, sep=",", na_rep='',

        self.header = header
        self.index = index
-        self.index_label = index_label
+        # if index label is not explicitly called, index label is True if


blank line here

jreback · 2019-03-24T18:37:37Z

pandas/io/formats/csvs.py

+        # if index label is not explicitly called, index label is True if
+        # header or index is not False; otherwise, index label is set to False
+        if index_label is None:
+            if self.header is False or self.header is None or not self.index:


can you update this

self.index_label = self.header or self.index

seems equivalent

jreback · 2019-03-24T18:38:53Z

pandas/io/formats/csvs.py

+                    # add empty string is name is None
+                    if name is None:
+                        name = ''
+                    index_label.append(name)


name or ''

jreback · 2019-03-24T18:39:45Z

pandas/io/formats/csvs.py

+        if index_label is True:
+            index_label = []
+            # append index label based on index type
+            if isinstance(obj.index, ABCMultiIndex):


can we not simply do
index_label = list(map(lambda name: name or '', obj.index.names))

jreback · 2019-03-24T18:40:02Z

pandas/io/formats/csvs.py

+                    index_label.append(name)
+            else:
+                # if no name, use empty string
+                if obj.index.name is None:


i don't htink you need this branch at all

i think it's needed, and looks like if the branch is removed, lots of tests will fail

see above the cases for multiindex and index are the same.

jreback

this needs to be a lot simpler as indicated.

jreback · 2019-03-25T23:49:30Z

pandas/io/formats/csvs.py

+        # if index label is not explicitly called, index label is True if
+        # header or index is not False; otherwise, index label is set to False
+        if index_label is None:
+            if self.header is False or self.header is None or not self.index:


try bool(self.header) or self.index then

jreback · 2019-03-25T23:50:09Z

pandas/io/formats/csvs.py

+                    index_label.append(name)
+            else:
+                # if no name, use empty string
+                if obj.index.name is None:


see above the cases for multiindex and index are the same.

WillAyd · 2019-05-03T05:41:09Z

@charlesdong1991 can you merge master and address comments?

simonjayhawkins · 2019-05-31T15:40:28Z

@charlesdong1991 can you merge master and address comments?

WillAyd · 2019-06-27T03:14:56Z

Closing as stale but ping if you'd like to pick this back up!

charlesdong1991 changed the title ~~Index Name is not displayed with header=False in to_csv~~ BUG: Index Name is not displayed with header=False in to_csv Jan 19, 2019

jreback added the IO CSV read_csv, to_csv label Jan 19, 2019

jreback requested changes Jan 19, 2019

View reviewed changes

jreback requested a review from gfyoung January 19, 2019 21:45

jreback added the Output-Formatting __repr__ of pandas objects, to_string label Jan 19, 2019

gfyoung mentioned this pull request Jan 19, 2019

(row) Index Name is not displayed with header=False master tracker #24546

Open

5 tasks

gfyoung reviewed Jan 19, 2019

View reviewed changes

simonjayhawkins reviewed Jan 19, 2019

View reviewed changes

simonjayhawkins mentioned this pull request Jan 20, 2019

Make DataFrame.to_html output full content #24841

Merged

4 tasks

jreback requested changes Jan 20, 2019

View reviewed changes

simonjayhawkins reviewed Jan 21, 2019

View reviewed changes

jreback requested changes Jan 21, 2019

View reviewed changes

simonjayhawkins reviewed Jan 21, 2019

View reviewed changes

charlesdong1991 force-pushed the index_name_to_csv branch from cdf1a6a to 92db032 Compare February 28, 2019 20:26

WillAyd requested changes Mar 1, 2019

View reviewed changes

merge master

1d5237e

charlesdong1991 force-pushed the index_name_to_csv branch from 275d390 to 1d5237e Compare March 3, 2019 10:16

charlesdong1991 added 2 commits March 24, 2019 16:30

Merge remote-tracking branch 'github/master' into index_name_to_csv

89e83ab

add gh

a617b10

jreback requested changes Mar 24, 2019

View reviewed changes

change based on review

3dc0027

jreback requested changes Mar 25, 2019

View reviewed changes

WillAyd closed this Jun 27, 2019

	def _get_column_name_list(self):
	names = []
	columns = self.frame.columns
	if isinstance(columns, ABCMultiIndex):
	names.extend('' if name is None else name
	for name in columns.names)
	else:
	names.append('' if columns.name is None else columns.name)
	return names

		@@ -120,6 +120,7 @@ def test_to_csv_from_csv3(self):

		df1.to_csv(path)
		df2.to_csv(path, mode='a', header=False)

	if self.header is False or self.header is None or not self.index:
	if not (self.header or self.index):

BUG: Index Name is not displayed with header=False in to_csv #24840

BUG: Index Name is not displayed with header=False in to_csv #24840

Conversation

charlesdong1991 commented Jan 19, 2019 • edited by gfyoung Loading

codecov bot commented Jan 19, 2019

Codecov Report

codecov bot commented Jan 19, 2019 • edited Loading

Codecov Report

jreback left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jreback commented Jan 19, 2019

charlesdong1991 commented Jan 19, 2019

simonjayhawkins commented Jan 19, 2019

simonjayhawkins commented Jan 19, 2019

gfyoung commented Jan 19, 2019

gfyoung commented Jan 19, 2019

Choose a reason for hiding this comment

gfyoung Jan 19, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

simonjayhawkins commented Jan 19, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gfyoung commented Jan 19, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pep8speaks commented Jan 20, 2019 • edited Loading

Comment last updated at 2019-03-24 22:25:00 UTC

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

charlesdong1991 Jan 21, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

charlesdong1991 Jan 21, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

charlesdong1991 commented Jan 21, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

WillAyd commented Feb 28, 2019

charlesdong1991 commented Feb 28, 2019

Choose a reason for hiding this comment

charlesdong1991 Mar 1, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

charlesdong1991 commented Mar 1, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

WillAyd commented Mar 19, 2019

charlesdong1991 commented Mar 24, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

charlesdong1991 commented Jan 19, 2019 •

edited by gfyoung

Loading

codecov bot commented Jan 19, 2019 •

edited

Loading

gfyoung Jan 19, 2019 •

edited

Loading

pep8speaks commented Jan 20, 2019 •

edited

Loading

charlesdong1991 Jan 21, 2019 •

edited

Loading

charlesdong1991 Jan 21, 2019 •

edited

Loading

charlesdong1991 Mar 1, 2019 •

edited

Loading