Skip to content

use Timedelta instead of convert_to_timedelta64 #24821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 18, 2019

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@codecov
Copy link

codecov bot commented Jan 18, 2019

Codecov Report

Merging #24821 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24821      +/-   ##
==========================================
- Coverage   92.38%   92.38%   -0.01%     
==========================================
  Files         166      166              
  Lines       52379    52378       -1     
==========================================
- Hits        48392    48390       -2     
- Misses       3987     3988       +1
Flag Coverage Δ
#multiple 90.81% <100%> (-0.01%) ⬇️
#single 42.91% <25%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/tools/timedeltas.py 98% <100%> (-0.04%) ⬇️
pandas/util/testing.py 88.04% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 512830b...d1bc2c1. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 18, 2019

Codecov Report

Merging #24821 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24821      +/-   ##
==========================================
- Coverage   92.38%   92.38%   -0.01%     
==========================================
  Files         166      166              
  Lines       52379    52378       -1     
==========================================
- Hits        48392    48391       -1     
  Misses       3987     3987
Flag Coverage Δ
#multiple 90.81% <100%> (-0.01%) ⬇️
#single 42.91% <25%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/tools/timedeltas.py 98% <100%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bbe418...8c6d63e. Read the comment docs.

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prob can now change convert_to_timedelta64 to cdef from cpdef

@jreback jreback added the Timedelta Timedelta data type label Jan 18, 2019
@jbrockmendel
Copy link
Member Author

prob can now change convert_to_timedelta64 to cdef from cpdef

Good idea. Also removed some util.is_array checks that can never be True.

@jreback jreback added this to the 0.24.0 milestone Jan 18, 2019
@jreback jreback merged commit a07d685 into pandas-dev:master Jan 18, 2019
@jreback
Copy link
Contributor

jreback commented Jan 18, 2019

thanks!

@jbrockmendel jbrockmendel deleted the ct2 branch January 18, 2019 22:41
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Timedelta Timedelta data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants