-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
use Timedelta instead of convert_to_timedelta64 #24821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24821 +/- ##
==========================================
- Coverage 92.38% 92.38% -0.01%
==========================================
Files 166 166
Lines 52379 52378 -1
==========================================
- Hits 48392 48390 -2
- Misses 3987 3988 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24821 +/- ##
==========================================
- Coverage 92.38% 92.38% -0.01%
==========================================
Files 166 166
Lines 52379 52378 -1
==========================================
- Hits 48392 48391 -1
Misses 3987 3987
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prob can now change convert_to_timedelta64 to cdef
from cpdef
Good idea. Also removed some util.is_array checks that can never be True. |
thanks! |
git diff upstream/master -u -- "*.py" | flake8 --diff