Skip to content

TST/CLN: follow-up to #24750 #24810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2019
Merged

TST/CLN: follow-up to #24750 #24810

merged 1 commit into from
Jan 17, 2019

Conversation

simonjayhawkins
Copy link
Member

cc @jreback

test_where_unsafe_itemsize_fail changed to test_where_upcast in #24750

this follow-on PR merges test_where_upcast into test_where_unsafe_upcast to avoid duplication.

@codecov
Copy link

codecov bot commented Jan 16, 2019 •
edited
Loading

Codecov Report

Merging #24810 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24810   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files         166      166           
  Lines       52382    52382           
=======================================
  Hits        48395    48395           
  Misses       3987     3987
Flag Coverage Δ
#multiple 90.81% <ø> (ø) ⬆️
#single 42.92% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17a6bc5...f8e5af0. Read the comment docs.

@jschendel jschendel added Testing pandas testing functions or related to the test suite Clean labels Jan 17, 2019
@jreback jreback added this to the 0.24.0 milestone Jan 17, 2019
@jreback jreback merged commit 9f4357b into pandas-dev:master Jan 17, 2019
@jreback
Copy link
Contributor

jreback commented Jan 17, 2019

thanks!

@simonjayhawkins simonjayhawkins deleted the test-boolean branch January 20, 2019 22:36
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@simonjayhawkins @Pingviinituutti
TST/CLN: follow-up to pandas-dev#24750 (pandas-dev#24810)
91ba263
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@simonjayhawkins @Pingviinituutti
TST/CLN: follow-up to pandas-dev#24750 (pandas-dev#24810)
37cf1f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@simonjayhawkins @jreback @jschendel