Skip to content

Whatsnew reorganization #24799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TomAugspurger
Copy link
Contributor

Changes

  1. Adds a highlights section (open to suggestions on what should be added / removed from here)
  2. Reorders the enhcancements section to be
    1. Highlighted features
    2. Other features (sections)
    3. List of other new features (one-liners)
  3. Reorders the "Backwards incompatible changes" section. We had two lists of "other incompatible changes" that I've merged into one at the end of the section.
  4. Moved extension type changes out of the "Backwards incompatible changes section".

cc @jorisvandenbossche

@TomAugspurger TomAugspurger added this to the 0.24.0 milestone Jan 16, 2019
- :func:`pd.offsets.generate_range` argument ``time_rule`` has been removed; use ``offset`` instead (:issue:`24157`)
- In 0.23.x, pandas would raise a ``ValueError`` on a merge of a numeric column (e.g. ``int`` dtyped column) and an ``object`` dtyped column (:issue:`9780`). We have re-enabled the ability to merge ``object`` and other dtypes; pandas will still raise on a merge between a numeric and an ``object`` dtyped column that is composed only of strings (:issue:`21681`)

Percentage change on groupby
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section was collapsed into a single line in https://github.com/pandas-dev/pandas/pull/24799/files#diff-f7aa70fb13c1915d211d6a0257977262R1812. I don't think it's a backwards incompatible change.

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That more or less exactly the clean-up I also wanted to do :)

* :ref:`New APIs for accessing the array backing a Series or Index <whatsnew_0240.values_api>`
* :ref:`A new top-level method for creating arrays <whatsnew_0240.enhancements.array>`
* :ref:`Store Interval and Period data in a Series or DataFrame <whatsnew_0240.enhancements.interval>`
* :ref:`Support for joining on two MultiIndexes <whatsnew_0240.enhancements.join_with_two_multiindexes>`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also add something about the sparse changes?

Or something about the "general improvements of the ExtensionArray interface" (although that is maybe too advanced / niche for the average user)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Highlight: If you were using SparseArrays we probably broke your code :)

I'm planning to go into much more detail about the extension array stuff in the blog post, so slightly inclined to not say too much here, as it's probably not directly relevant for the average user.

@jreback
Copy link
Contributor

jreback commented Jan 16, 2019

lgtm. after CI fixes are merge, let's repush and merge on green.

@codecov
Copy link

codecov bot commented Jan 16, 2019

Codecov Report

Merging #24799 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24799      +/-   ##
==========================================
+ Coverage   42.92%   42.94%   +0.02%     
==========================================
  Files         166      166              
  Lines       52382    52382              
==========================================
+ Hits        22485    22498      +13     
+ Misses      29897    29884      -13
Flag Coverage Δ
#single 42.94% <ø> (+0.02%) ⬆️
Impacted Files Coverage Δ
pandas/io/json/json.py 62.85% <0%> (+1.19%) ⬆️
pandas/core/internals/construction.py 64.21% <0%> (+2.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b99f8bc...6c603d0. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 16, 2019

Codecov Report

Merging #24799 into master will increase coverage by 49.46%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #24799       +/-   ##
===========================================
+ Coverage   42.92%   92.38%   +49.46%     
===========================================
  Files         166      166               
  Lines       52382    52382               
===========================================
+ Hits        22485    48395    +25910     
+ Misses      29897     3987    -25910
Flag Coverage Δ
#multiple 90.81% <ø> (?)
#single 42.92% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/computation/pytables.py 92.37% <0%> (+0.3%) ⬆️
pandas/io/pytables.py 92.31% <0%> (+0.92%) ⬆️
pandas/util/_test_decorators.py 90.54% <0%> (+4.05%) ⬆️
pandas/compat/__init__.py 57.91% <0%> (+8.1%) ⬆️
pandas/core/config_init.py 99.24% <0%> (+9.84%) ⬆️
pandas/core/reshape/util.py 100% <0%> (+11.53%) ⬆️
pandas/core/api.py 100% <0%> (+13.33%) ⬆️
pandas/compat/numpy/__init__.py 92.85% <0%> (+14.28%) ⬆️
pandas/core/computation/common.py 85.71% <0%> (+14.28%) ⬆️
pandas/core/indexes/api.py 99% <0%> (+14.85%) ⬆️
... and 123 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98f46f7...bd1a319. Read the comment docs.

@TomAugspurger
Copy link
Contributor Author

TomAugspurger commented Jan 16, 2019

Gonna just fix the merge conflict and merge if that's OK (other PR removed a section).

@TomAugspurger TomAugspurger merged commit 0bf62b3 into pandas-dev:master Jan 16, 2019
@TomAugspurger TomAugspurger deleted the whatsnew-reorganization branch January 16, 2019 16:23

**Equality and Hashability**

Pandas now requires that extension dtypes be hashable. The base class implements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems I'm a bit too late to mention this on time. In #22476 (comment), we talked about this line.

How about: Pandas now requires that extension dtypes be hashable (i.e. the respective ExtensionDtype-objects; hashability is not a requirement for the values of the corresponding ExtensionArray).

@h-vetinari
Copy link
Contributor

@TomAugspurger

Seems that comment about the hashable dtype we talked about hasn't made it into master yet. Just mentioning if you still wanna do that before release.

@TomAugspurger
Copy link
Contributor Author

TomAugspurger commented Jan 24, 2019 via email

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants