TST: Add test for C parser handling binary mode #24797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
added
Testing
|
Hoping your errors will be fixed by #24707 |
|
lgtm. after CI fixes are merge, let's repush and merge on green. |
Python's native CSV library doesn't accept such files, but we do for the C parser. Closes pandas-devgh-23779.
gfyoung
force-pushed
the
c-parser-binary-mode-file-test
branch
from
0729d6e to
cbe8804
Compare
Codecov Report
@@ Coverage Diff @@
## master #24797 +/- ##
===========================================
- Coverage 92.38% 42.93% -49.46%
===========================================
Files 166 166
Lines 52382 52382
===========================================
- Hits 48395 22488 -25907
- Misses 3987 29894 +25907
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24797 +/- ##
==========================================
- Coverage 92.38% 92.38% -0.01%
==========================================
Files 166 166
Lines 52382 52382
==========================================
- Hits 48395 48394 -1
- Misses 3987 3988 +1
Continue to review full report at Codecov.
|
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Python's native CSV library doesn't accept such files, but we do for the C parser. Closes pandas-devgh-23779.
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Python's native CSV library doesn't accept such files, but we do for the C parser. Closes pandas-devgh-23779.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python's native CSV library doesn't accept such files, but we do for the C parser.
Closes #23779.