-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CI: Pinning flake8-rst, last version raises incorrect errors #24756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Pinning flake8-rst, last version raises incorrect errors #24756
Conversation
@@ -14,7 +14,7 @@ dependencies: | |||
- cython>=0.28.2 | |||
- flake8 | |||
- flake8-comprehensions | |||
- flake8-rst>=0.6.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just make >=0.6.0<=0.7.0 for now
done |
cool. merge on pass. |
Codecov Report
@@ Coverage Diff @@
## master #24756 +/- ##
===========================================
- Coverage 92.38% 42.91% -49.47%
===========================================
Files 166 166
Lines 52363 52363
===========================================
- Hits 48376 22473 -25903
- Misses 3987 29890 +25903
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24756 +/- ##
=======================================
Coverage 92.38% 92.38%
=======================================
Files 166 166
Lines 52363 52363
=======================================
Hits 48376 48376
Misses 3987 3987
Continue to review full report at Codecov.
|
|
Just saw it, luckily the syntax for >= and <= seems to be the same in pip as in conda, will push in a second, after I finish testing. |
git diff upstream/master -u -- "*.py" | flake8 --diff
CC: @jreback @FHaase