-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CLN: More isort #24745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLN: More isort #24745
Conversation
Hello @alimcmaster1! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on January 12, 2019 at 22:30 Hours UTC |
Codecov Report
@@ Coverage Diff @@
## master #24745 +/- ##
===========================================
- Coverage 92.38% 43.07% -49.32%
===========================================
Files 166 166
Lines 52358 52358
===========================================
- Hits 48373 22554 -25819
- Misses 3985 29804 +25819
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24745 +/- ##
=======================================
Coverage 92.38% 92.38%
=======================================
Files 166 166
Lines 52358 52358
=======================================
Hits 48373 48373
Misses 3985 3985
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a fan of isort, but lgtm
thanks! |
git diff upstream/master -u -- "*.py" | flake8 --diff
Hopefully nearing the end of these now..