ModuleNotFoundError in in_interactive_session #24714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dickreuter
changed the title
ModuleNotFoundErrorin 'in_interactive_session' (:issue:24690`)ModuleNotFoundError in 'in_interactive_session' (:issue:24690)
Codecov Report
@@ Coverage Diff @@
## master #24714 +/- ##
==========================================
- Coverage 92.38% 92.38% -0.01%
==========================================
Files 166 166
Lines 52311 52324 +13
==========================================
+ Hits 48328 48338 +10
- Misses 3983 3986 +3
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24714 +/- ##
==========================================
- Coverage 92.38% 92.38% -0.01%
==========================================
Files 166 166
Lines 52321 52324 +3
==========================================
+ Hits 48338 48339 +1
- Misses 3983 3985 +2
Continue to review full report at Codecov.
|
doc/source/whatsnew/v0.24.0.rst
Outdated
| @@ -1748,6 +1748,7 @@ I/O | |||
| - Bug in :meth:`DataFrame.to_stata`, :class:`pandas.io.stata.StataWriter` and :class:`pandas.io.stata.StataWriter117` where a exception would leave a partially written and invalid dta file (:issue:`23573`) | |||
| - Bug in :meth:`DataFrame.to_stata` and :class:`pandas.io.stata.StataWriter117` that produced invalid files when using strLs with non-ASCII characters (:issue:`23573`) | |||
| - Bug in :class:`HDFStore` that caused it to raise ``ValueError`` when reading a Dataframe in Python 3 from fixed format written in Python 2 (:issue:`24510`) | |||
| - Bug in :func:`in_interactive_session` that caused it to raise ``ModuleNotFoundError`` (:issue:`24690`) | |||
There was a problem hiding this comment.
I don't think in_interactive_session is part of the public API. This should be user-facing.
There was a problem hiding this comment.
yeah I don't think we even need this note
jreback
changed the title
ModuleNotFoundError in 'in_interactive_session' (:issue:24690)
jreback
requested changes
Jan 11, 2019
doc/source/whatsnew/v0.24.0.rst
Outdated
| @@ -1748,6 +1748,7 @@ I/O | |||
| - Bug in :meth:`DataFrame.to_stata`, :class:`pandas.io.stata.StataWriter` and :class:`pandas.io.stata.StataWriter117` where a exception would leave a partially written and invalid dta file (:issue:`23573`) | |||
| - Bug in :meth:`DataFrame.to_stata` and :class:`pandas.io.stata.StataWriter117` that produced invalid files when using strLs with non-ASCII characters (:issue:`23573`) | |||
| - Bug in :class:`HDFStore` that caused it to raise ``ValueError`` when reading a Dataframe in Python 3 from fixed format written in Python 2 (:issue:`24510`) | |||
| - Bug in :func:`in_interactive_session` that caused it to raise ``ModuleNotFoundError`` (:issue:`24690`) | |||
There was a problem hiding this comment.
yeah I don't think we even need this note
|
@REJack, remove the note |
jreback
added
Compat
jreback
approved these changes
Jan 13, 2019
|
thanks! |
|
Hmm I still wasn't sure we should merge this. Can we check with upstream to
see if their workaround can be applied for py2 only?
Or can we add a TODO to remove this when we drop Python2?
…On Sun, Jan 13, 2019 at 1:17 PM Jeff Reback ***@***.***> wrote:
thanks!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#24714 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHItXs_RGnK_SmfJFGyA1DImwWHaWrks5vC4ZWgaJpZM4Z6WTF>
.
|
|
Not sure I understand. The pylint issue is affecting both py2 and py3 I think. Or why do you think there’s a difference?
… On 13 Jan 2019, at 19:23, Tom Augspurger ***@***.***> wrote:
Hmm I still wasn't sure we should merge this. Can we check with upstream to
see if their workaround can be applied for py2 only?
Or can we add a TODO to remove this when we drop Python2?
On Sun, Jan 13, 2019 at 1:17 PM Jeff Reback ***@***.***>
wrote:
> thanks!
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#24714 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABQHItXs_RGnK_SmfJFGyA1DImwWHaWrks5vC4ZWgaJpZM4Z6WTF>
> .
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
From the linked bug report in
https://github.com/PyCQA/pylint/blob/master/pylint/lint.py#L153 to
https://bugs.python.org/issue10845,
it seems to be fixed in python 3.2. So it's possible that pylint could
apply that mock only for Python <=2.7
On Sun, Jan 13, 2019 at 1:30 PM Nicolas Dickreuter <[email protected]>
wrote:
… Not sure I understand. The pylint issue is affecting both py2 and py3 I
think. Or why do you think there’s a difference?
> On 13 Jan 2019, at 19:23, Tom Augspurger ***@***.***>
wrote:
>
> Hmm I still wasn't sure we should merge this. Can we check with upstream
to
> see if their workaround can be applied for py2 only?
>
> Or can we add a TODO to remove this when we drop Python2?
>
> On Sun, Jan 13, 2019 at 1:17 PM Jeff Reback ***@***.***>
> wrote:
>
> > thanks!
> >
> > —
> > You are receiving this because you commented.
> > Reply to this email directly, view it on GitHub
> > <
#24714 (comment)>,
> > or mute the thread
> > <
https://github.com/notifications/unsubscribe-auth/ABQHItXs_RGnK_SmfJFGyA1DImwWHaWrks5vC4ZWgaJpZM4Z6WTF
>
> > .
> >
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub, or mute the thread.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#24714 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIg2btBiGKv--kIUFnYfsh6Uie6Hxks5vC4lJgaJpZM4Z6WTF>
.
|
|
I see. I have submitted a PR for Pylint as well to remove the mock, but
their release cycle is very slow.
On Sun, 13 Jan 2019 at 19:44, Tom Augspurger <[email protected]>
wrote:
… From the linked bug report in
https://github.com/PyCQA/pylint/blob/master/pylint/lint.py#L153 to
https://bugs.python.org/issue10845,
it seems to be fixed in python 3.2. So it's possible that pylint could
apply that mock only for Python <=2.7
On Sun, Jan 13, 2019 at 1:30 PM Nicolas Dickreuter <
***@***.***>
wrote:
> Not sure I understand. The pylint issue is affecting both py2 and py3 I
> think. Or why do you think there’s a difference?
>
> > On 13 Jan 2019, at 19:23, Tom Augspurger ***@***.***>
> wrote:
> >
> > Hmm I still wasn't sure we should merge this. Can we check with
upstream
> to
> > see if their workaround can be applied for py2 only?
> >
> > Or can we add a TODO to remove this when we drop Python2?
> >
> > On Sun, Jan 13, 2019 at 1:17 PM Jeff Reback ***@***.***>
> > wrote:
> >
> > > thanks!
> > >
> > > —
> > > You are receiving this because you commented.
> > > Reply to this email directly, view it on GitHub
> > > <
> #24714 (comment)>,
> > > or mute the thread
> > > <
>
https://github.com/notifications/unsubscribe-auth/ABQHItXs_RGnK_SmfJFGyA1DImwWHaWrks5vC4ZWgaJpZM4Z6WTF
> >
> > > .
> > >
> > —
> > You are receiving this because you authored the thread.
> > Reply to this email directly, view it on GitHub, or mute the thread.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#24714 (comment)
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/ABQHIg2btBiGKv--kIUFnYfsh6Uie6Hxks5vC4lJgaJpZM4Z6WTF
>
> .
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#24714 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABMrfjPrSFnwBJeIfI03VsFGSQp-tno4ks5vC4yOgaJpZM4Z6WTF>
.
|
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff