CLN: Removing find_undoc_args.py, validate_docstrings.py implements the same #24693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datapythonista
changed the title
|
sure merge away |
Codecov Report
@@ Coverage Diff @@
## master #24693 +/- ##
=======================================
Coverage 92.38% 92.38%
=======================================
Files 166 166
Lines 52310 52310
=======================================
Hits 48326 48326
Misses 3984 3984
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #24693 +/- ##
=======================================
Coverage 92.38% 92.38%
=======================================
Files 166 166
Lines 52310 52310
=======================================
Hits 48326 48326
Misses 3984 3984
Continue to review full report at Codecov.
|
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script
find_undoc_args.pywas used to detect functions that the documented parameters did not match the signature ones.validate_docstrings.pyimplements the same validation, among many more. So the script is not needed anymore.