Skip to content

Have DTA._simple_new take dtype instead of tz #24665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2019

Conversation

jbrockmendel
Copy link
Member

Allows for better code-sharing. I'm pretty sure after this we can get rid of _get_attributes_dict

@codecov
Copy link

codecov bot commented Jan 7, 2019

Codecov Report

Merging #24665 into master will decrease coverage by <.01%.
The diff coverage is 96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24665      +/-   ##
==========================================
- Coverage   92.37%   92.37%   -0.01%     
==========================================
  Files         166      166              
  Lines       52315    52322       +7     
==========================================
+ Hits        48328    48333       +5     
- Misses       3987     3989       +2
Flag Coverage Δ
#multiple 90.79% <96%> (-0.01%) ⬇️
#single 43.07% <68%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/internals/blocks.py 94.3% <ø> (ø) ⬆️
pandas/core/indexes/datetimes.py 96.27% <100%> (+0.01%) ⬆️
pandas/core/arrays/datetimes.py 97.71% <100%> (+0.03%) ⬆️
pandas/tseries/offsets.py 96.69% <100%> (ø) ⬆️
pandas/core/arrays/datetimelike.py 97.67% <80%> (-0.19%) ⬇️
pandas/util/testing.py 88% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ae466c...bee17cd. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 7, 2019

Codecov Report

Merging #24665 into master will decrease coverage by <.01%.
The diff coverage is 96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24665      +/-   ##
==========================================
- Coverage   92.37%   92.37%   -0.01%     
==========================================
  Files         166      166              
  Lines       52315    52322       +7     
==========================================
+ Hits        48328    48333       +5     
- Misses       3987     3989       +2
Flag Coverage Δ
#multiple 90.79% <96%> (-0.01%) ⬇️
#single 43.07% <68%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/internals/blocks.py 94.3% <ø> (ø) ⬆️
pandas/core/indexes/datetimes.py 96.27% <100%> (+0.01%) ⬆️
pandas/core/arrays/datetimes.py 97.71% <100%> (+0.03%) ⬆️
pandas/tseries/offsets.py 96.69% <100%> (ø) ⬆️
pandas/core/arrays/datetimelike.py 97.67% <80%> (-0.19%) ⬇️
pandas/util/testing.py 88% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ae466c...bee17cd. Read the comment docs.

@jreback jreback added the Internals Related to non-user accessible pandas implementation label Jan 8, 2019
@jreback jreback added this to the 0.24.0 milestone Jan 8, 2019
@jreback jreback added the Datetime Datetime data dtype label Jan 8, 2019
@jreback jreback merged commit fbd39d9 into pandas-dev:master Jan 8, 2019
@jreback
Copy link
Contributor

jreback commented Jan 8, 2019

thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the simple_tzs branch January 8, 2019 16:47
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Datetime Datetime data dtype Internals Related to non-user accessible pandas implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants