Skip to content

API: Datetime/TimedeltaArray from to_datetime #24660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 8, 2019
Merged

API: Datetime/TimedeltaArray from to_datetime #24660

merged 3 commits into from
Jan 8, 2019

Conversation

TomAugspurger
Copy link
Contributor

Closes #24656

@TomAugspurger TomAugspurger added Datetime Datetime data dtype Dtype Conversions Unexpected or buggy dtype conversions ExtensionArray Extending pandas with custom dtypes or arrays. labels Jan 7, 2019
@TomAugspurger TomAugspurger added this to the 0.24.0 milestone Jan 7, 2019
@codecov
Copy link

codecov bot commented Jan 7, 2019

Codecov Report

Merging #24660 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24660      +/-   ##
==========================================
+ Coverage   92.37%   92.37%   +<.01%     
==========================================
  Files         166      166              
  Lines       52384    52388       +4     
==========================================
+ Hits        48391    48395       +4     
  Misses       3993     3993
Flag Coverage Δ
#multiple 90.8% <100%> (ø) ⬆️
#single 43.01% <20%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/array_.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4994ca...21007f2. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 7, 2019 •
edited
Loading

Codecov Report

Merging #24660 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24660      +/-   ##
==========================================
+ Coverage   92.37%   92.37%   +<.01%     
==========================================
  Files         166      166              
  Lines       52324    52328       +4     
==========================================
+ Hits        48336    48340       +4     
  Misses       3988     3988
Flag Coverage Δ
#multiple 90.8% <100%> (ø) ⬆️
#single 43.06% <20%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/arrays/array_.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f57bd72...351c781. Read the comment docs.

@TomAugspurger
Copy link
Contributor Author

cc @jorisvandenbossche.

Do the docs make sense, or do they just cause more confusion?

jreback
jreback requested changes Jan 8, 2019
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comments otherwise lgtm.

@jreback
Copy link
Contributor

jreback commented Jan 8, 2019

lgtm merge on green.

@TomAugspurger TomAugspurger merged commit 6bd1705 into pandas-dev:master Jan 8, 2019
@TomAugspurger TomAugspurger deleted the pd.array-dt-array branch January 8, 2019 19:40
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@TomAugspurger @Pingviinituutti
API: Datetime/TimedeltaArray from to_datetime (pandas-dev#24660)
f42dff1 
* API: Datetime/TimedeltaArray from to_datetime

Closes pandas-dev#24656
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@TomAugspurger @Pingviinituutti
API: Datetime/TimedeltaArray from to_datetime (pandas-dev#24660)
4ed3de0 
* API: Datetime/TimedeltaArray from to_datetime

Closes pandas-dev#24656
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche left review comments

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Datetime Datetime data dtype Dtype Conversions Unexpected or buggy dtype conversions ExtensionArray Extending pandas with custom dtypes or arrays.
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@TomAugspurger @jreback @jorisvandenbossche