Skip to content

Make DTA/TDA/PA return NotImplemented on comparisons #24643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 5, 2019

Conversation

jbrockmendel
Copy link
Member

Before implementing a boilerplate decorator like in #24282, going through to standardize the affected behaviors.

@jreback jreback added the Internals Related to non-user accessible pandas implementation label Jan 5, 2019
@codecov
Copy link

codecov bot commented Jan 5, 2019

Codecov Report

Merging #24643 into master will decrease coverage by <.01%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24643      +/-   ##
==========================================
- Coverage   92.37%   92.37%   -0.01%     
==========================================
  Files         166      166              
  Lines       52379    52382       +3     
==========================================
+ Hits        48386    48387       +1     
- Misses       3993     3995       +2
Flag Coverage Δ
#multiple 90.79% <90%> (-0.01%) ⬇️
#single 43.02% <50%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/arrays/period.py 98.52% <100%> (-0.02%) ⬇️
pandas/core/arrays/datetimes.py 97.69% <100%> (-0.16%) ⬇️
pandas/core/indexes/datetimelike.py 98.52% <100%> (ø) ⬆️
pandas/core/arrays/timedeltas.py 88.03% <50%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d106e99...33cdf67. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 5, 2019

Codecov Report

Merging #24643 into master will decrease coverage by <.01%.
The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24643      +/-   ##
==========================================
- Coverage   92.37%   92.37%   -0.01%     
==========================================
  Files         166      166              
  Lines       52379    52383       +4     
==========================================
+ Hits        48386    48388       +2     
- Misses       3993     3995       +2
Flag Coverage Δ
#multiple 90.79% <92.3%> (-0.01%) ⬇️
#single 43.02% <61.53%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/arrays/period.py 98.52% <100%> (-0.02%) ⬇️
pandas/core/arrays/datetimes.py 97.69% <100%> (-0.16%) ⬇️
pandas/core/indexes/datetimelike.py 98.52% <100%> (+0.01%) ⬆️
pandas/core/arrays/timedeltas.py 88.03% <50%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d106e99...b69c2cb. Read the comment docs.

@jreback jreback added this to the 0.24.0 milestone Jan 5, 2019
@jreback
Copy link
Contributor

jreback commented Jan 5, 2019

lgtm ping on green.

@jbrockmendel
Copy link
Member Author

ping

@jreback jreback merged commit 9ceccec into pandas-dev:master Jan 5, 2019
@jreback
Copy link
Contributor

jreback commented Jan 5, 2019

thanks!

@jbrockmendel jbrockmendel deleted the pi_defer branch January 5, 2019 21:59
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internals Related to non-user accessible pandas implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants