Skip to content

REF: io/formats/html.py (and io/formats/format.py) #24637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 5, 2019
Merged

REF: io/formats/html.py (and io/formats/format.py) #24637

merged 4 commits into from
Jan 5, 2019

Conversation

simonjayhawkins
Copy link
Member

@simonjayhawkins simonjayhawkins commented Jan 5, 2019 •
edited
Loading

  • [ n/a] closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • [ n/a] whatsnew entry

@codecov
Copy link

codecov bot commented Jan 5, 2019

Codecov Report

Merging #24637 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24637      +/-   ##
==========================================
- Coverage   92.37%   92.37%   -0.01%     
==========================================
  Files         166      166              
  Lines       52388    52380       -8     
==========================================
- Hits        48396    48388       -8     
  Misses       3992     3992
Flag Coverage Δ
#multiple 90.8% <100%> (-0.01%) ⬇️
#single 43.01% <21.87%> (+0.01%) ⬆️
Impacted Files Coverage Δ
pandas/io/formats/html.py 99.34% <100%> (-0.03%) ⬇️
pandas/io/formats/format.py 97.98% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 510afa7...5825c18. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 5, 2019 •
edited
Loading

Codecov Report

Merging #24637 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24637      +/-   ##
==========================================
- Coverage   92.37%   92.37%   -0.01%     
==========================================
  Files         166      166              
  Lines       52388    52380       -8     
==========================================
- Hits        48396    48388       -8     
  Misses       3992     3992
Flag Coverage Δ
#multiple 90.8% <100%> (-0.01%) ⬇️
#single 43.01% <21.87%> (+0.01%) ⬆️
Impacted Files Coverage Δ
pandas/io/formats/html.py 99.34% <100%> (-0.03%) ⬇️
pandas/io/formats/format.py 97.98% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 510afa7...5825c18. Read the comment docs.

@jreback jreback added Output-Formatting __repr__ of pandas objects, to_string IO HTML read_html, to_html, Styler.apply, Styler.applymap labels Jan 5, 2019
@jreback jreback added this to the 0.24.0 milestone Jan 5, 2019
@jreback
Copy link
Contributor

jreback commented Jan 5, 2019

lgtm.

@jreback jreback merged commit 3ae4229 into pandas-dev:master Jan 5, 2019
@jreback
Copy link
Contributor

jreback commented Jan 5, 2019

thanks!

@simonjayhawkins simonjayhawkins deleted the html-refactor branch January 5, 2019 21:05
@simonjayhawkins simonjayhawkins mentioned this pull request Jan 6, 2019
Merged
2 tasks
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@simonjayhawkins @Pingviinituutti
REF: io/formats/html.py (and io/formats/format.py) (pandas-dev#24637)
98933ec
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@simonjayhawkins @Pingviinituutti
REF: io/formats/html.py (and io/formats/format.py) (pandas-dev#24637)
265d91b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
IO HTML read_html, to_html, Styler.apply, Styler.applymap Output-Formatting __repr__ of pandas objects, to_string
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@simonjayhawkins @jreback