-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TST: Fixed timezone issues post DatetimeArray refactor #24634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pandas/tests/frame/test_reshape.py
Outdated
'a': ['a'], | ||
'b': ['b'], | ||
'c': ['c'], | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like this may need a columns=['timestamp', 'a', 'b', 'c']
to ensure the right order on Py2.
lgtm ex @TomAugspurger comment, ping on green. |
@mroeschke can you merge master |
Codecov Report
@@ Coverage Diff @@
## master #24634 +/- ##
===========================================
+ Coverage 43.02% 92.37% +49.35%
===========================================
Files 166 166
Lines 52384 52395 +11
===========================================
+ Hits 22539 48402 +25863
+ Misses 29845 3993 -25852
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24634 +/- ##
=======================================
Coverage 92.37% 92.37%
=======================================
Files 166 166
Lines 52384 52384
=======================================
Hits 48390 48390
Misses 3994 3994
Continue to review full report at Codecov.
|
thanks @mroeschke |
git diff upstream/master -u -- "*.py" | flake8 --diff