Skip to content

TST: Fixed timezone issues post DatetimeArray refactor #24634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 6, 2019

Conversation

'a': ['a'],
'b': ['b'],
'c': ['c'],
})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this may need a columns=['timestamp', 'a', 'b', 'c'] to ensure the right order on Py2.

@jreback jreback added Reshaping Concat, Merge/Join, Stack/Unstack, Explode Timezones Timezone data dtype labels Jan 5, 2019
@jreback jreback added this to the 0.24.0 milestone Jan 5, 2019
@jreback
Copy link
Contributor

jreback commented Jan 5, 2019

lgtm ex @TomAugspurger comment, ping on green.

@jreback
Copy link
Contributor

jreback commented Jan 5, 2019

@mroeschke can you merge master

@codecov
Copy link

codecov bot commented Jan 5, 2019

Codecov Report

Merging #24634 into master will increase coverage by 49.35%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #24634       +/-   ##
===========================================
+ Coverage   43.02%   92.37%   +49.35%     
===========================================
  Files         166      166               
  Lines       52384    52395       +11     
===========================================
+ Hits        22539    48402    +25863     
+ Misses      29845     3993    -25852
Flag Coverage Δ
#multiple 90.8% <ø> (?)
#single 43% <ø> (-0.02%) ⬇️
Impacted Files Coverage Δ
pandas/core/computation/pytables.py 92.37% <0%> (+0.3%) ⬆️
pandas/io/pytables.py 92.31% <0%> (+0.92%) ⬆️
pandas/util/_test_decorators.py 90.54% <0%> (+4.05%) ⬆️
pandas/compat/__init__.py 57.91% <0%> (+8.1%) ⬆️
pandas/core/config_init.py 99.24% <0%> (+9.84%) ⬆️
pandas/core/reshape/util.py 100% <0%> (+11.53%) ⬆️
pandas/core/api.py 100% <0%> (+13.33%) ⬆️
pandas/compat/numpy/__init__.py 92.85% <0%> (+14.28%) ⬆️
pandas/core/computation/common.py 85.71% <0%> (+14.28%) ⬆️
pandas/core/indexes/api.py 99% <0%> (+14.85%) ⬆️
... and 123 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc91f4c...d660481. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 5, 2019

Codecov Report

Merging #24634 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24634   +/-   ##
=======================================
  Coverage   92.37%   92.37%           
=======================================
  Files         166      166           
  Lines       52384    52384           
=======================================
  Hits        48390    48390           
  Misses       3994     3994
Flag Coverage Δ
#multiple 90.8% <ø> (ø) ⬆️
#single 43.02% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc91f4c...d660481. Read the comment docs.

@jreback jreback merged commit 393d0aa into pandas-dev:master Jan 6, 2019
@jreback
Copy link
Contributor

jreback commented Jan 6, 2019

thanks @mroeschke

@mroeschke mroeschke deleted the tz_tests_fixed branch January 6, 2019 18:04
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment