Skip to content

REF: dispatch Series.quantile to DataFrame, remove ScalarBlock #24606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 4, 2019

Conversation

jbrockmendel
Copy link
Member

ScalarBlock exists because sometimes Block.quantile needs to return a scalar. By having Series dispatch to DataFrame, we simplify quantile in internals an get to remove ScalarBlock and make_block_scalar

@jreback jreback added Numeric Operations Arithmetic, Comparison, and Logical operations Clean labels Jan 4, 2019
@jreback jreback added this to the 0.24.0 milestone Jan 4, 2019
@jreback
Copy link
Contributor

jreback commented Jan 4, 2019

lgtm. nice to get rid of this hack. do a git blame sometime and you will see who did this code :> (you have to go back before you moved it)

@codecov
Copy link

codecov bot commented Jan 4, 2019

Codecov Report

Merging #24606 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24606      +/-   ##
==========================================
- Coverage   92.38%   92.37%   -0.01%     
==========================================
  Files         166      166              
  Lines       52490    52474      -16     
==========================================
- Hits        48493    48473      -20     
- Misses       3997     4001       +4
Flag Coverage Δ
#multiple 90.8% <100%> (-0.02%) ⬇️
#single 43.05% <9.09%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/internals/__init__.py 100% <ø> (ø) ⬆️
pandas/core/internals/managers.py 96.05% <100%> (+0.08%) ⬆️
pandas/core/internals/blocks.py 94.21% <100%> (-0.33%) ⬇️
pandas/core/series.py 93.56% <100%> (+0.02%) ⬆️
pandas/core/nanops.py 94.36% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9175387...a21dd35. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 4, 2019

Codecov Report

Merging #24606 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24606      +/-   ##
==========================================
- Coverage   92.38%   92.37%   -0.01%     
==========================================
  Files         166      166              
  Lines       52490    52474      -16     
==========================================
- Hits        48493    48473      -20     
- Misses       3997     4001       +4
Flag Coverage Δ
#multiple 90.8% <100%> (-0.02%) ⬇️
#single 43.05% <9.09%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/internals/__init__.py 100% <ø> (ø) ⬆️
pandas/core/internals/managers.py 96.05% <100%> (+0.08%) ⬆️
pandas/core/internals/blocks.py 94.21% <100%> (-0.33%) ⬇️
pandas/core/series.py 93.56% <100%> (+0.02%) ⬆️
pandas/core/nanops.py 94.36% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9175387...a21dd35. Read the comment docs.

@jreback jreback merged commit 1574b0e into pandas-dev:master Jan 4, 2019
@jreback
Copy link
Contributor

jreback commented Jan 4, 2019

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Numeric Operations Arithmetic, Comparison, and Logical operations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants