-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
REF: dispatch Series.quantile to DataFrame, remove ScalarBlock #24606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lgtm. nice to get rid of this hack. do a git blame sometime and you will see who did this code :> (you have to go back before you moved it) |
Codecov Report
@@ Coverage Diff @@
## master #24606 +/- ##
==========================================
- Coverage 92.38% 92.37% -0.01%
==========================================
Files 166 166
Lines 52490 52474 -16
==========================================
- Hits 48493 48473 -20
- Misses 3997 4001 +4
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #24606 +/- ##
==========================================
- Coverage 92.38% 92.37% -0.01%
==========================================
Files 166 166
Lines 52490 52474 -16
==========================================
- Hits 48493 48473 -20
- Misses 3997 4001 +4
Continue to review full report at Codecov.
|
thanks! |
ScalarBlock exists because sometimes Block.quantile needs to return a scalar. By having Series dispatch to DataFrame, we simplify quantile in internals an get to remove ScalarBlock and make_block_scalar