-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Fixed PeriodIndex._shallow_copy for i8 #24604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lgtm. |
Codecov Report
@@ Coverage Diff @@
## master #24604 +/- ##
==========================================
- Coverage 43.05% 43.05% -0.01%
==========================================
Files 166 166
Lines 52471 52482 +11
==========================================
+ Hits 22593 22595 +2
- Misses 29878 29887 +9
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24604 +/- ##
==========================================
- Coverage 92.37% 92.37% -0.01%
==========================================
Files 166 166
Lines 52471 52470 -1
==========================================
- Hits 48471 48469 -2
- Misses 4000 4001 +1
Continue to review full report at Codecov.
|
Had to update a few places using this. One in resample. We were using this for PI/TDI/DTI to change the freq. It only worked since the object was empty. The others were tests using the |
All green now. |
thanks @TomAugspurger |
1 similar comment
thanks @TomAugspurger |
Closes #24391
cc @jschendel