Remove unhittable methods in internals #24594
Conversation
| axis=axis, **kw) | ||
| except ValueError: | ||
|
|
||
| # older numpies don't handle an array for q |
There was a problem hiding this comment.
I'm actually just assuming here that the relevant old numpies can by dropped. @h-vetinari any idea on this?
There was a problem hiding this comment.
Sorry I was too late too see this. Can't really tell from first glance what's going on, but can have a second look if desired.
| @@ -2400,8 +2346,6 @@ def _maybe_coerce_values(self, values, dtype=None): | |||
| values = self._holder(values) | |||
|
|
|||
| if dtype is not None: | |||
| if isinstance(dtype, compat.string_types): | |||
| dtype = DatetimeTZDtype.construct_from_string(dtype) | |||
There was a problem hiding this comment.
let the DatetimeArray constructor handle this
| def _try_cast_result(self, result, dtype=None): | ||
| return result | ||
|
|
||
| def _unstack(self, unstacker_func, new_columns, n_rows, fill_value): |
There was a problem hiding this comment.
this and the two methods above are in NonConsolodateableMixin, which is now only mixed in to ExtensionBlock, which directly defines these three methods.
|
lgtm. some lint issues. ping on green. |
Codecov Report
@@ Coverage Diff @@
## master #24594 +/- ##
==========================================
+ Coverage 92.36% 92.38% +0.02%
==========================================
Files 166 166
Lines 52497 52478 -19
==========================================
- Hits 48490 48483 -7
+ Misses 4007 3995 -12
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24594 +/- ##
==========================================
+ Coverage 92.36% 92.38% +0.02%
==========================================
Files 166 166
Lines 52497 52478 -19
==========================================
- Hits 48490 48483 -7
+ Misses 4007 3995 -12
Continue to review full report at Codecov.
|
|
ping |
|
thanks! |
And one more 24024 in test cleanup