DOC: Correct description of day_opt in shift_month #24585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
added
Docs
Datetime
Codecov Report
@@ Coverage Diff @@
## master #24585 +/- ##
==========================================
- Coverage 92.36% 92.36% -0.01%
==========================================
Files 166 166
Lines 52497 52497
==========================================
- Hits 48490 48489 -1
- Misses 4007 4008 +1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #24585 +/- ##
==========================================
- Coverage 92.36% 92.36% -0.01%
==========================================
Files 166 166
Lines 52497 52497
==========================================
- Hits 48490 48489 -1
- Misses 4007 4008 +1
Continue to review full report at Codecov.
|
|
this is in a few more places in this file i think as well (same edit needed) |
|
@jreback : Good point. I'll do that in a follow-up. |
gfyoung
added a commit
to forking-repos/pandas
that referenced
this pull request
Jan 3, 2019
Unlike shift_month, all other descriptions do not mention support of "None" as a value, since it is not supported in the other functions. Follow-up to pandas-devgh-24585.
gfyoung
added a commit
that referenced
this pull request
Jan 3, 2019
Unlike shift_month, all other descriptions do not mention support of "None" as a value, since it is not supported in the other functions. Follow-up to gh-24585.
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Unlike shift_month, all other descriptions do not mention support of "None" as a value, since it is not supported in the other functions. Follow-up to pandas-devgh-24585.
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Unlike shift_month, all other descriptions do not mention support of "None" as a value, since it is not supported in the other functions. Follow-up to pandas-devgh-24585.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doc is updated per implementation at 268150f.