Skip to content

Fix docstring templates not being filled (#24535) #24584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2019
Merged

Fix docstring templates not being filled (#24535) #24584

merged 1 commit into from
Jan 3, 2019

Conversation

fakabbir
Copy link
Contributor

@fakabbir fakabbir commented Jan 3, 2019

Fixes the docstring template issue

@codecov
Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #24584 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24584      +/-   ##
==========================================
- Coverage   92.36%   92.36%   -0.01%     
==========================================
  Files         166      166              
  Lines       52497    52497              
==========================================
- Hits        48490    48489       -1     
- Misses       4007     4008       +1
Flag Coverage Δ
#multiple 90.79% <ø> (ø) ⬆️
#single 43.04% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/indexes/base.py 96.29% <ø> (ø) ⬆️
pandas/util/testing.py 88% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 268150f...68e0cf5. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #24584 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24584      +/-   ##
==========================================
- Coverage   92.36%   92.36%   -0.01%     
==========================================
  Files         166      166              
  Lines       52497    52497              
==========================================
- Hits        48490    48489       -1     
- Misses       4007     4008       +1
Flag Coverage Δ
#multiple 90.79% <ø> (ø) ⬆️
#single 43.04% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/indexes/base.py 96.29% <ø> (ø) ⬆️
pandas/util/testing.py 88% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 268150f...68e0cf5. Read the comment docs.

@gfyoung gfyoung requested review from jbrockmendel and jreback and removed request for jbrockmendel January 3, 2019 10:30
Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks @fakabbir !

@gfyoung gfyoung requested a review from jbrockmendel January 3, 2019 10:31
@jreback jreback added this to the 0.24.0 milestone Jan 3, 2019
@jreback jreback merged commit db051b9 into pandas-dev:master Jan 3, 2019
@jreback
Copy link
Contributor

jreback commented Jan 3, 2019

thanks

@fakabbir fakabbir deleted the issue-24535 branch January 4, 2019 06:57
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docstring templates not being filled
3 participants