read_sas catches own error #24548

[benjaminr]

• closes read_sas catches own error #24548
• tests added / passed
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

[jreback]

needs a test & a whatsnew entry

[codecov]

Codecov Report

Merging #24554 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #24554      +/-   ##
==========================================
- Coverage   92.33%   92.33%   -0.01%     
==========================================
  Files         166      166              
  Lines       52465    52465              
==========================================
- Hits        48443    48442       -1     
- Misses       4022     4023       +1

Flag	Coverage Δ
#multiple	90.75% <0%> (ø)	⬆️
#single	43% <0%> (ø)	⬆️

Impacted Files	Coverage Δ
pandas/io/sas/sasreader.py	86.2% <0%> (ø)	⬆️
pandas/util/testing.py	87.59% <0%> (-0.1%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27d18c7...15bf0f9. Read the comment docs.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@c217656). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master   #24554   +/-   ##
=========================================
  Coverage          ?   92.32%           
=========================================
  Files             ?      166           
  Lines             ?    52553           
  Branches          ?        0           
=========================================
  Hits              ?    48519           
  Misses            ?     4034           
  Partials          ?        0

Flag	Coverage Δ
#multiple	90.75% <100%> (?)
#single	43.06% <0%> (?)

Impacted Files	Coverage Δ
pandas/io/sas/sasreader.py	96.15% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c217656...dcc071d. Read the comment docs.

[jreback]

minor comment, lgtm. ping on green.

[jreback]

i pushed a revision

[benjaminr]

@jreback Build appears to have mostly passed apart from Windows which is reporting:

"Could not find conda environment: pandas-dev" - not sure this is related to what I've changed.

Relates to #24564

[TomAugspurger]

restarted the azure build.

[jreback]

thanks!