Skip to content

WIP: make _holder changeover #24540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

WIP: make _holder changeover #24540

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0f687c1
make _holder changeover
jbrockmendel Jan 1, 2019
d422941
implement test_datetime
jbrockmendel Jan 1, 2019
483597b
port necessary edits from 24024
jbrockmendel Jan 1, 2019
007b167
update test with new expected behavior
jbrockmendel Jan 2, 2019
5fdb073
fix a couple more tests
jbrockmendel Jan 2, 2019
63145cd
Fix pickle-based errors
jbrockmendel Jan 2, 2019
9b12f98
fix json test
jbrockmendel Jan 2, 2019
e76ad68
compat for pytables test
jbrockmendel Jan 2, 2019
39436a2
Merge branch 'master' of https://github.com/pandas-dev/pandas into race
jbrockmendel Jan 2, 2019
45a4ae7
implement ravel
jbrockmendel Jan 2, 2019
e50e662
Merge branch 'master' of https://github.com/pandas-dev/pandas into race
jbrockmendel Jan 2, 2019
2e6310c
fix lint typo
jbrockmendel Jan 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pandas/core/arrays/datetimelike.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,6 +414,13 @@ def _formatter(self, boxed=False):
# ----------------------------------------------------------------
# Array-Like / EA-Interface Methods

@property
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might as well add ravel for now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to avoid adding these if possible.

What requires this? Was it for pytables IO?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

transpose was for a pytables test, yah. we discussed it briefly over in 24024. I prefer adding it, but not gonna fuss over it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(also until i get the packers tests and one last feather test fixed I'm completely stuck)

def transpose(self):
# no-op because we are always 1-D
return self

T = transpose

@property
def nbytes(self):
return self._data.nbytes
Expand Down