MAINT: Port _timelex in codebase #24520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
added
Testing
gfyoung
force-pushed
the
timelex-port
branch
from
7b88b7b to
2a1500d
Compare
Codecov Report
@@ Coverage Diff @@
## master #24520 +/- ##
=======================================
Coverage 31.88% 31.88%
=======================================
Files 166 166
Lines 52434 52434
=======================================
Hits 16718 16718
Misses 35716 35716
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24520 +/- ##
=======================================
Coverage 31.88% 31.88%
=======================================
Files 166 166
Lines 52413 52413
=======================================
Hits 16714 16714
Misses 35699 35699
Continue to review full report at Codecov.
|
pganssle
reviewed
Dec 31, 2018
|
General approach seems right to me. I'll try to keep you informed if we make major changes in |
gfyoung
force-pushed
the
timelex-port
branch
from
2a1500d to
29febe3
Compare
jreback
requested changes
Dec 31, 2018
pganssle
reviewed
Dec 31, 2018
pganssle
reviewed
Dec 31, 2018
jbrockmendel
approved these changes
Jan 1, 2019
Removes the DeprecationWarning raised by dateutil because it's a private class. Implementation taken from the following PR: dateutil/dateutil#732 Closes pandas-devgh-21322.
|
@jreback : Starting 2019 off on a good note with an all green PR! 🎉 All requested changes have been made, and all is green. PTAL. |
jreback
approved these changes
Jan 1, 2019
|
thanks @gfyoung @jbrockmendel and @pganssle |
thoo
added a commit
to thoo/pandas
that referenced
this pull request
Jan 1, 2019
* upstream/master: BUG: output formatting with to_html(), index=False and/or index_names=False (pandas-dev#22579, pandas-dev#22747) (pandas-dev#22655) MAINT: Port _timelex in codebase (pandas-dev#24520) Implement unique+array parts of 24024 (pandas-dev#24527) Integer NA docs (pandas-dev#23617)
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
* MAINT: Port _timelex in codebase Removes the DeprecationWarning raised by dateutil because it's a private class. Implementation taken from the following PR: dateutil/dateutil#732 Closes pandas-devgh-21322. * MAINT: Drop _timelex compat for dateutil 2.2
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
* MAINT: Port _timelex in codebase Removes the DeprecationWarning raised by dateutil because it's a private class. Implementation taken from the following PR: dateutil/dateutil#732 Closes pandas-devgh-21322. * MAINT: Drop _timelex compat for dateutil 2.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
DeprecationWarningraised bydateutilbecause it's a private class.Implementation taken from the following PR:
dateutil/dateutil#732
Closes #21322.
cc @pganssle