Skip to content

BUG/TST: Fix corrwith index #24519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 31, 2018
Merged

BUG/TST: Fix corrwith index #24519

merged 1 commit into from
Dec 31, 2018

Conversation

dsaxton
Copy link
Member

@dsaxton dsaxton commented Dec 31, 2018

In PR 22375 the reindexing behavior of DataFrame.corrwith was modified to handle duplicate columns. This PR adds tests to help ensure correct behavior of the index.

@codecov
Copy link

codecov bot commented Dec 31, 2018

Codecov Report

Merging #24519 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24519   +/-   ##
=======================================
  Coverage   31.88%   31.88%           
=======================================
  Files         166      166           
  Lines       52434    52434           
=======================================
  Hits        16718    16718           
  Misses      35716    35716
Flag Coverage Δ
#multiple 30.28% <ø> (ø) ⬆️
#single 31.88% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/frame.py 27.82% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf9d41c...2a987e3. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 31, 2018

Codecov Report

Merging #24519 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24519   +/-   ##
=======================================
  Coverage   31.88%   31.88%           
=======================================
  Files         166      166           
  Lines       52434    52434           
=======================================
  Hits        16718    16718           
  Misses      35716    35716
Flag Coverage Δ
#multiple 30.28% <ø> (ø) ⬆️
#single 31.88% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf9d41c...2a987e3. Read the comment docs.

@dsaxton
Copy link
Member Author

dsaxton commented Dec 31, 2018

(Please disregard the title of the PR, there is no bug)

@jreback jreback added Bug Numeric Operations Arithmetic, Comparison, and Logical operations labels Dec 31, 2018
@jreback jreback added this to the 0.24.0 milestone Dec 31, 2018
@jreback jreback merged commit b434da5 into pandas-dev:master Dec 31, 2018
@jreback
Copy link
Contributor

jreback commented Dec 31, 2018

thanks @dsaxton

@dsaxton dsaxton deleted the idx-fix branch January 1, 2019 01:18
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Numeric Operations Arithmetic, Comparison, and Logical operations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants