Skip to content

CLN: Remove dead code in api/test_types.py #24516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 31, 2018
Merged

CLN: Remove dead code in api/test_types.py #24516

merged 1 commit into from
Dec 31, 2018

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Dec 31, 2018

Follow-up to #19769.

@gfyoung gfyoung added Testing pandas testing functions or related to the test suite Clean labels Dec 31, 2018
@gfyoung gfyoung added this to the 0.24.0 milestone Dec 31, 2018
@codecov
Copy link

codecov bot commented Dec 31, 2018

Codecov Report

Merging #24516 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24516   +/-   ##
=======================================
  Coverage   31.88%   31.88%           
=======================================
  Files         166      166           
  Lines       52434    52434           
=======================================
  Hits        16718    16718           
  Misses      35716    35716
Flag Coverage Δ
#multiple 30.28% <ø> (ø) ⬆️
#single 31.88% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 449d665...d5d6ad7. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Dec 31, 2018

Codecov Report

Merging #24516 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24516   +/-   ##
=======================================
  Coverage   31.88%   31.88%           
=======================================
  Files         166      166           
  Lines       52434    52434           
=======================================
  Hits        16718    16718           
  Misses      35716    35716
Flag Coverage Δ
#multiple 30.28% <ø> (ø) ⬆️
#single 31.88% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 449d665...d5d6ad7. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 31, 2018 •
edited
Loading

Codecov Report

Merging #24516 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24516   +/-   ##
=======================================
  Coverage   31.88%   31.88%           
=======================================
  Files         166      166           
  Lines       52434    52434           
=======================================
  Hits        16718    16718           
  Misses      35716    35716
Flag Coverage Δ
#multiple 30.28% <ø> (ø) ⬆️
#single 31.88% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 449d665...d5d6ad7. Read the comment docs.

@gfyoung gfyoung merged commit bf9d41c into pandas-dev:master Dec 31, 2018
@gfyoung gfyoung deleted the api-test-types-dead-code branch December 31, 2018 19:06
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@gfyoung @Pingviinituutti
CLN: Remove dead code in api/test_types.py (pandas-dev#24516)
3ea99e6 
Follow-up to pandas-devgh-19769.
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@gfyoung @Pingviinituutti
CLN: Remove dead code in api/test_types.py (pandas-dev#24516)
813ed70 
Follow-up to pandas-devgh-19769.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
1 participant
@gfyoung