Skip to content

MAINT: Use context manager in test_c_parser_only #24512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Dec 31, 2018

Specifically, use context manager for pytest.raises.

xref #24332.

Specifically, use context manager for pytest.raises.

xref pandas-devgh-24332.
@gfyoung gfyoung added Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite labels Dec 31, 2018
@gfyoung gfyoung added this to the 0.24.0 milestone Dec 31, 2018
@codecov
Copy link

codecov bot commented Dec 31, 2018

Codecov Report

Merging #24512 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24512   +/-   ##
=======================================
  Coverage   31.89%   31.89%           
=======================================
  Files         166      166           
  Lines       52421    52421           
=======================================
  Hits        16722    16722           
  Misses      35699    35699
Flag Coverage Δ
#multiple 30.29% <ø> (ø) ⬆️
#single 31.89% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 100ffff...b715f10. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 31, 2018

Codecov Report

Merging #24512 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24512   +/-   ##
=======================================
  Coverage   31.89%   31.89%           
=======================================
  Files         166      166           
  Lines       52421    52421           
=======================================
  Hits        16722    16722           
  Misses      35699    35699
Flag Coverage Δ
#multiple 30.29% <ø> (ø) ⬆️
#single 31.89% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 100ffff...b715f10. Read the comment docs.

@jreback jreback merged commit 2b82159 into pandas-dev:master Dec 31, 2018
@jreback
Copy link
Contributor

jreback commented Dec 31, 2018

thanks

@gfyoung gfyoung deleted the test-c-parser-only-pytest-ctx branch December 31, 2018 18:00
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Specifically, use context manager for pytest.raises.

xref pandas-devgh-24332.
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Specifically, use context manager for pytest.raises.

xref pandas-devgh-24332.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants