Skip to content

TST: don't skip test_datapath_missing if not --strict-data-files #24481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 29, 2018
Merged

TST: don't skip test_datapath_missing if not --strict-data-files #24481

merged 1 commit into from
Dec 29, 2018

Conversation

simonjayhawkins
Copy link
Member

don't skip test_datapath_missing if not --strict-data-files

@jreback jreback added the Testing pandas testing functions or related to the test suite label Dec 29, 2018
@jreback jreback added this to the 0.24.0 milestone Dec 29, 2018
@jreback
Copy link
Contributor

jreback commented Dec 29, 2018

lgtm ping on green.

@codecov
Copy link

codecov bot commented Dec 29, 2018

Codecov Report

Merging #24481 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24481   +/-   ##
=======================================
  Coverage   92.32%   92.32%           
=======================================
  Files         166      166           
  Lines       52306    52306           
=======================================
  Hits        48294    48294           
  Misses       4012     4012
Flag Coverage Δ
#multiple 90.75% <ø> (ø) ⬆️
#single 43.06% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c8c5df...d788c4d. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 29, 2018 •
edited
Loading

Codecov Report

Merging #24481 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24481   +/-   ##
=======================================
  Coverage   92.32%   92.32%           
=======================================
  Files         166      166           
  Lines       52306    52306           
=======================================
  Hits        48294    48294           
  Misses       4012     4012
Flag Coverage Δ
#multiple 90.75% <ø> (ø) ⬆️
#single 43.06% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c8c5df...d788c4d. Read the comment docs.

@simonjayhawkins
Copy link
Member Author

@jreback green!

@jreback jreback merged commit 3f83627 into pandas-dev:master Dec 29, 2018
@jreback
Copy link
Contributor

jreback commented Dec 29, 2018

thanks!

@simonjayhawkins simonjayhawkins deleted the strict-data-files branch December 29, 2018 15:11
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@simonjayhawkins @Pingviinituutti
test_datapath_missing (pandas-dev#24481)
7f8890e
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@simonjayhawkins @Pingviinituutti
test_datapath_missing (pandas-dev#24481)
30f20b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@simonjayhawkins @jreback