Skip to content

TST- Fixing issue with test_parquet test unexpectedly passing #24480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 30, 2018
Merged

TST- Fixing issue with test_parquet test unexpectedly passing #24480

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d9bc62d
Fixing issue with test_parquet passing
RjLi13 Dec 29, 2018
3a17930
add in fp and pyarrow
jreback Dec 29, 2018
c3cbc8f
Merge branch 'master' into PR_TOOL_MERGE_PR_24480
jreback Dec 29, 2018
e3c29e2
Merge branch 'master' into PR_TOOL_MERGE_PR_24480
jreback Dec 29, 2018
9f7e6aa
remove macosx xfail
jreback Dec 29, 2018
ba384ba
Fix linting issue
RjLi13 Dec 29, 2018
41427a3
removing xfail completely
RjLi13 Dec 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pandas/tests/io/test_parquet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,8 @@ def test_options_get_engine(fp, pa):


@pytest.mark.xfail(is_platform_windows() or is_platform_mac(),
Copy link
Contributor

@TomAugspurger TomAugspurger Dec 29, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try removing the xfail entirely? It looks like it may be unnecessary now.

Copy link
Contributor Author

@RjLi13 RjLi13 Dec 29, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did do that in another branch and it passed the CI tests of travis, but it seems there's discussion of pyarrow and fastparquet as well as windows causing problems? Not completely sure.

Edit: Also passed CI tests in azure

reason="reading pa metadata failing on Windows/mac")
reason="reading pa metadata failing on Windows/mac",
strict=False)
def test_cross_engine_pa_fp(df_cross_compat, pa, fp):
# cross-compat with differing reading/writing engines

Expand Down