Skip to content

CI: Moving 3 jobs from travis to azure #24460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 28, 2018
Merged

CI: Moving 3 jobs from travis to azure #24460

merged 2 commits into from
Dec 28, 2018

Conversation

datapythonista
Copy link
Member

We currently have 8 jobs in travis, and 7 jobs in azure. But in azure we've got 30 concurrent jobs, and in travis 15, making travis our bottleneck.

Here I move 3 jobs from travis to azure, so we have 10 in travis, and 5 in azure. This should keep things balanced for now, and both CI systems should more or less be synchronized.

I moved the 3 jobs that don't run the db tests (we don't have mysql or postgres in azure at the moment), and left in travis the ones that do use the db, and the two "allow failures" ones.

@datapythonista datapythonista added the CI Continuous Integration label Dec 28, 2018
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i prefer travis to be honest so move some less
important ones are ok

.travis.yml Outdated
@@ -32,18 +32,6 @@ matrix:
- python: 3.5

include:
- dist: trusty
env:
- JOB="3.7" ENV_FILE="ci/deps/travis-37.yaml" PATTERN="not slow and not network"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave the main 3.7 one here and pick another (the 3.6 is ok)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that we don't have mysql or postgresql in azure. The ones I moved are the ones that do not run the database tests.

I can leave the main 3.7 in travis, but we'll have the CI unbalanced, and will have to wait for travis (less than now if I move the other 2).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these this one, the balance is fine now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved 3.7 back to travis

@codecov
Copy link

codecov bot commented Dec 28, 2018

Codecov Report

Merging #24460 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24460   +/-   ##
=======================================
  Coverage    92.3%    92.3%           
=======================================
  Files         163      163           
  Lines       51969    51969           
=======================================
  Hits        47968    47968           
  Misses       4001     4001
Flag Coverage Δ
#multiple 90.7% <ø> (ø) ⬆️
#single 43.01% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa1549f...b66a11a. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 28, 2018

Codecov Report

Merging #24460 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24460   +/-   ##
=======================================
  Coverage    92.3%    92.3%           
=======================================
  Files         163      163           
  Lines       51969    51969           
=======================================
  Hits        47968    47968           
  Misses       4001     4001
Flag Coverage Δ
#multiple 90.7% <ø> (ø) ⬆️
#single 43.01% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa1549f...b0383c8. Read the comment docs.

.travis.yml Outdated
@@ -32,18 +32,6 @@ matrix:
- python: 3.5

include:
- dist: trusty
env:
- JOB="3.7" ENV_FILE="ci/deps/travis-37.yaml" PATTERN="not slow and not network"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these this one, the balance is fine now.

@jreback jreback added this to the 0.24.0 milestone Dec 28, 2018
@jreback
Copy link
Contributor

jreback commented Dec 28, 2018

lgtm ping on green.

@jreback jreback merged commit ab55d05 into pandas-dev:master Dec 28, 2018
@jreback
Copy link
Contributor

jreback commented Dec 28, 2018

thanks @datapythonista

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants