TST: move mi tests from tests/indexing/ to tests/indexing/multiindex/ #24417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #24417 +/- ##
==========================================
- Coverage 92.3% 92.3% -0.01%
==========================================
Files 163 163
Lines 51950 51946 -4
==========================================
- Hits 47953 47949 -4
Misses 3997 3997
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24417 +/- ##
==========================================
+ Coverage 92.3% 92.3% +<.01%
==========================================
Files 163 163
Lines 51950 51954 +4
==========================================
+ Hits 47953 47957 +4
Misses 3997 3997
Continue to review full report at Codecov.
|
jreback
requested changes
Dec 25, 2018
| import pandas.util.testing as tm | ||
|
|
||
|
|
||
| class TestIndexingSlow(object): |
There was a problem hiding this comment.
is this needed to be class based?
| @@ -5,7 +5,8 @@ | |||
| from pandas.util import testing as tm | |||
|
|
|||
|
|
|||
| @pytest.mark.filterwarnings('ignore:\\nPanel:FutureWarning') | |||
| @pytest.mark.filterwarnings('ignore::FutureWarning') | |||
| # @pytest.mark.filterwarnings('ignore:\\nPanel:FutureWarning') | |||
| df['A'] = df['A'].astype(np.float64) | ||
| tm.assert_index_equal(df.index, index) | ||
|
|
||
| # TODO(wesm): unused variables |
| import pytest | ||
|
|
||
| import pandas as pd | ||
| from pandas.core.api import DataFrame, MultiIndex, Series | ||
| from pandas.core.api import DataFrame |
jreback
added
Testing
jreback
approved these changes
Dec 25, 2018
| keys = [randint(0, 11, m), choice( | ||
| list('abcdefghijk'), m), choice( | ||
| pd.date_range('20141009', periods=11).tolist(), m), choice( | ||
| list('ZYXWVUTSRQP'), m)] |
There was a problem hiding this comment.
ideally would like to split this massive test up, but as a followup
|
thanks @simonjayhawkins very nice. |
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff