-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: Fix groupby observed=True when aggregating a column #24412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 15 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
debb02a
GH23970 Added test-case that causes bug 23970
Koustav-Samaddar f450dc2
GH 23970 Fixed source of the bug
Koustav-Samaddar 3b50900
GH23970 Added relevant docstring to whatsnew
Koustav-Samaddar e6e9894
Made requested change to docstring
Koustav-Samaddar 5181639
Made requested changes to tests
Koustav-Samaddar 4c68d41
Fixed typo from incomplete find/replace
Koustav-Samaddar 77cf3c6
Fixed pep8 violation
Koustav-Samaddar 572d9c3
Fixed pep's E128 violation
Koustav-Samaddar 8793995
Fixed another possible pep violation
Koustav-Samaddar b75bc7b
Fixed whatsnew entryto meet in the middle
Koustav-Samaddar ef48de6
Merge branch 'master' into bug-23970
Koustav-Samaddar d87e159
Test has been modified to have parameterised as_index
Koustav-Samaddar b01d809
Fixed pep8 issues in test file
Koustav-Samaddar 7a6898f
Made recommended change to whatsnew
Koustav-Samaddar d584327
Merged for git pull
Koustav-Samaddar 3e9178a
Changed test to use assert_equal
Koustav-Samaddar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you an use assert_equal here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Didn't know about that one