Skip to content

CI: Fixes to the patterns code checks #24410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 24, 2018
Merged

CI: Fixes to the patterns code checks #24410

merged 1 commit into from
Dec 24, 2018

Conversation

datapythonista
Copy link
Member

Fixing couple of small errors in the CI (detected in https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=5707):

  • When the patterns (grep unwanted patterns) step fails, the installation of flake8... is cancelled
  • When a file has a blank line with whitespaces, the reported error is not clear

@datapythonista datapythonista added the CI Continuous Integration label Dec 24, 2018
@codecov
Copy link

codecov bot commented Dec 24, 2018

Codecov Report

Merging #24410 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24410      +/-   ##
==========================================
+ Coverage    92.3%    92.3%   +<.01%     
==========================================
  Files         163      163              
  Lines       51943    51943              
==========================================
+ Hits        47946    47947       +1     
+ Misses       3997     3996       -1
Flag Coverage Δ
#multiple 90.71% <ø> (ø) ⬆️
#single 42.99% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/util/testing.py 87.84% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc7bc3f...9a0e321. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 24, 2018

Codecov Report

Merging #24410 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24410      +/-   ##
==========================================
+ Coverage    92.3%    92.3%   +<.01%     
==========================================
  Files         163      163              
  Lines       51943    51943              
==========================================
+ Hits        47946    47947       +1     
+ Misses       3997     3996       -1
Flag Coverage Δ
#multiple 90.71% <ø> (ø) ⬆️
#single 42.99% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/util/testing.py 87.84% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc7bc3f...9a0e321. Read the comment docs.

@jreback jreback added this to the 0.24.0 milestone Dec 24, 2018
@jreback jreback merged commit a71c121 into pandas-dev:master Dec 24, 2018
@jreback
Copy link
Contributor

jreback commented Dec 24, 2018

thanks @datapythonista

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants