Skip to content

REF/TST: Add more pytest idiom to indexing/multiindex/test_getitem.py #24409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 24, 2018

Conversation

simonjayhawkins
Copy link
Member

@simonjayhawkins simonjayhawkins commented Dec 24, 2018

in this pass:

@codecov
Copy link

codecov bot commented Dec 24, 2018

Codecov Report

Merging #24409 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24409   +/-   ##
=======================================
  Coverage    92.3%    92.3%           
=======================================
  Files         163      163           
  Lines       51943    51943           
=======================================
  Hits        47946    47946           
  Misses       3997     3997
Flag Coverage Δ
#multiple 90.71% <ø> (ø) ⬆️
#single 43% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc7bc3f...d73a620. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 24, 2018

Codecov Report

Merging #24409 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24409   +/-   ##
=======================================
  Coverage    92.3%    92.3%           
=======================================
  Files         163      163           
  Lines       51943    51943           
=======================================
  Hits        47946    47946           
  Misses       3997     3997
Flag Coverage Δ
#multiple 90.71% <ø> (ø) ⬆️
#single 43% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc7bc3f...d73a620. Read the comment docs.

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Refactor Internal refactoring of code labels Dec 24, 2018
@jreback jreback added this to the 0.24.0 milestone Dec 24, 2018
@jreback jreback merged commit 195cbef into pandas-dev:master Dec 24, 2018
@jreback
Copy link
Contributor

jreback commented Dec 24, 2018

thanks @simonjayhawkins

@jreback
Copy link
Contributor

jreback commented Dec 24, 2018

I think these are no longer filtered?

=============================================================================================================================== warnings summary ================================================================================================================================
pandas/tests/indexing/multiindex/test_getitem.py::test_series_getitem_fancy[<lambda>1]
  /Users/jreback/pandas/pandas/tests/indexing/multiindex/test_getitem.py:173: DeprecationWarning: 
  .ix is deprecated. Please use
  .loc for label based indexing or
  .iloc for positional indexing
  
  See the documentation here:
  http://pandas.pydata.org/pandas-docs/stable/indexing.html#ix-indexer-is-deprecated
    lambda s: s.ix[[(2000, 3, 10), (2000, 3, 13)]]

pandas/tests/indexing/multiindex/test_getitem.py::test_getitem_tuple_plus_slice
  /Users/jreback/pandas/pandas/tests/indexing/multiindex/test_getitem.py:232: DeprecationWarning: 
  .ix is deprecated. Please use
  .loc for label based indexing or
  .iloc for positional indexing
  
  See the documentation here:
  http://pandas.pydata.org/pandas-docs/stable/indexing.html#ix-indexer-is-deprecated
    expected3 = idf.ix[0, 0]

-- Docs: http://doc.pytest.org/en/latest/warnings.html

@simonjayhawkins
Copy link
Member Author

@jreback . it appears that pytest is no longer behaving with regex.. could be pytest-dev/pytest#3936. but i've not checked thoroughly.

for the meantime i'm not currently replacing any with catch_warnings(record=True): or simplefilter("ignore", DeprecationWarning) and relying on pytest.

the other alternative is to be less explicit and use @pytest.mark.filterwarnings("ignore::DeprecationWarning") and then maybe return at a later date and add \\nPanel and \\n.ix etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants