Skip to content

REF/TST: Collect Straggler Arithmetic Tests #24376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 21, 2018

Conversation

jbrockmendel
Copy link
Member

After this AFAICT there are only 5 files left with possibly-misplaced arithmetic tests. Leaving those for another pass since some of them are testing type-specific behavior so will need a careful look.

Moved tests are unchanged except for contextifying pytest.raises where appropriate.

There's a hackathon in Feb I'm vaguely planning to use as a time to try to de-duplicate/parametrize the tests that have been moved to tests.arithmetic with TODO notes.

@pep8speaks
Copy link

Hello @jbrockmendel! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #24376 into master will decrease coverage by 49.31%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #24376       +/-   ##
===========================================
- Coverage   92.29%   42.98%   -49.32%     
===========================================
  Files         162      162               
  Lines       51841    51841               
===========================================
- Hits        47847    22282    -25565     
- Misses       3994    29559    +25565
Flag Coverage Δ
#multiple ?
#single 42.98% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/io/formats/latex.py 0% <0%> (-100%) ⬇️
pandas/core/categorical.py 0% <0%> (-100%) ⬇️
pandas/io/sas/sas_constants.py 0% <0%> (-100%) ⬇️
pandas/tseries/plotting.py 0% <0%> (-100%) ⬇️
pandas/tseries/converter.py 0% <0%> (-100%) ⬇️
pandas/io/formats/html.py 0% <0%> (-98.65%) ⬇️
pandas/core/groupby/categorical.py 0% <0%> (-95.46%) ⬇️
pandas/io/sas/sas7bdat.py 0% <0%> (-91.17%) ⬇️
pandas/io/sas/sas_xport.py 0% <0%> (-90.15%) ⬇️
pandas/core/tools/numeric.py 10.44% <0%> (-89.56%) ⬇️
... and 120 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d134ec...f19026c. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #24376 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24376   +/-   ##
=======================================
  Coverage   92.29%   92.29%           
=======================================
  Files         162      162           
  Lines       51841    51841           
=======================================
  Hits        47847    47847           
  Misses       3994     3994
Flag Coverage Δ
#multiple 90.7% <ø> (ø) ⬆️
#single 42.98% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d134ec...38e7f1f. Read the comment docs.

@jreback jreback added Testing pandas testing functions or related to the test suite Numeric Operations Arithmetic, Comparison, and Logical operations labels Dec 21, 2018
@jreback jreback added this to the 0.24.0 milestone Dec 21, 2018
@jreback jreback merged commit b36e06c into pandas-dev:master Dec 21, 2018
@jreback
Copy link
Contributor

jreback commented Dec 21, 2018

thanks!

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@jbrockmendel jbrockmendel deleted the ktests branch April 5, 2020 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Numeric Operations Arithmetic, Comparison, and Logical operations Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants