-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
REF/TST: Collect Straggler Arithmetic Tests #24376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @jbrockmendel! Thanks for submitting the PR.
|
Codecov Report
@@ Coverage Diff @@
## master #24376 +/- ##
===========================================
- Coverage 92.29% 42.98% -49.32%
===========================================
Files 162 162
Lines 51841 51841
===========================================
- Hits 47847 22282 -25565
- Misses 3994 29559 +25565
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24376 +/- ##
=======================================
Coverage 92.29% 92.29%
=======================================
Files 162 162
Lines 51841 51841
=======================================
Hits 47847 47847
Misses 3994 3994
Continue to review full report at Codecov.
|
thanks! |
After this AFAICT there are only 5 files left with possibly-misplaced arithmetic tests. Leaving those for another pass since some of them are testing type-specific behavior so will need a careful look.
Moved tests are unchanged except for contextifying pytest.raises where appropriate.
There's a hackathon in Feb I'm vaguely planning to use as a time to try to de-duplicate/parametrize the tests that have been moved to tests.arithmetic with TODO notes.