Skip to content

REF/TST: Add pytest idiom to test_testing #24369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2018

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Dec 20, 2018

Splits test file into multiple new files and delegates remaining tests to the miscellaneous test_util.py

@gfyoung gfyoung added Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite labels Dec 20, 2018
@gfyoung gfyoung added this to the 0.24.0 milestone Dec 20, 2018
@pep8speaks
Copy link

Hello @gfyoung! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #24369 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24369      +/-   ##
==========================================
+ Coverage   92.29%   92.29%   +<.01%     
==========================================
  Files         162      162              
  Lines       51832    51832              
==========================================
+ Hits        47839    47840       +1     
+ Misses       3993     3992       -1
Flag Coverage Δ
#multiple 90.7% <ø> (ø) ⬆️
#single 42.99% <ø> (+0.01%) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 87.75% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6cf7d9...d8720b6. Read the comment docs.

@pandas-dev pandas-dev deleted a comment from codecov bot Dec 20, 2018
Splits test file into multiple new files
and delegates remaining tests to the
miscellaneous test_util.py
@gfyoung gfyoung force-pushed the pytest-idiom-test-testing branch from d8720b6 to aca6404 Compare December 20, 2018 22:35
@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #24369 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24369      +/-   ##
==========================================
+ Coverage   92.29%   92.29%   +<.01%     
==========================================
  Files         162      162              
  Lines       51841    51841              
==========================================
+ Hits        47847    47849       +2     
+ Misses       3994     3992       -2
Flag Coverage Δ
#multiple 90.7% <ø> (ø) ⬆️
#single 42.98% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 87.75% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d134ec...aca6404. Read the comment docs.

@pandas-dev pandas-dev deleted a comment from codecov bot Dec 20, 2018
@jreback jreback merged commit 95f73c3 into pandas-dev:master Dec 21, 2018
@jreback
Copy link
Contributor

jreback commented Dec 21, 2018

thanks @gfyoung

@gfyoung gfyoung deleted the pytest-idiom-test-testing branch December 21, 2018 23:43
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Splits test file into multiple new files
and delegates remaining tests to the
miscellaneous test_util.py
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Splits test file into multiple new files
and delegates remaining tests to the
miscellaneous test_util.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants