Skip to content

CLN: simplify CategoricalIndex internals #24343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2018

Conversation

topper-123
Copy link
Contributor

Simplify method signatures of some internal methods of CategoricalIndex.

@pep8speaks
Copy link

Hello @topper-123! Thanks for submitting the PR.

@jreback jreback added Internals Related to non-user accessible pandas implementation Categorical Categorical Data Type labels Dec 18, 2018
@topper-123
Copy link
Contributor Author

The travis error is unrelated:

curl: (56) SSL read: error:00000000:lib(0):func(0):reason(0), errno 104
Unable to download 3.5 archive. The archive may not exist. Please consider a different version.

@jreback
Copy link
Contributor

jreback commented Dec 18, 2018

i restarted to make sure this passes. ping on green.

@jreback jreback added this to the 0.24.0 milestone Dec 18, 2018
@codecov
Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #24343 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24343      +/-   ##
==========================================
+ Coverage   92.28%   92.34%   +0.06%     
==========================================
  Files         162      162              
  Lines       51835    52217     +382     
==========================================
+ Hits        47834    48218     +384     
+ Misses       4001     3999       -2
Flag Coverage Δ
#multiple 90.75% <100%> (+0.07%) ⬆️
#single 43.16% <90%> (+0.16%) ⬆️
Impacted Files Coverage Δ
pandas/core/indexes/category.py 98.65% <100%> (+0.75%) ⬆️
pandas/util/testing.py 87.58% <0%> (+0.09%) ⬆️
pandas/core/arrays/datetimes.py 98.37% <0%> (+0.13%) ⬆️
pandas/core/resample.py 96.75% <0%> (+0.16%) ⬆️
pandas/tseries/offsets.py 97.24% <0%> (+0.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a34adac...6a5a1f7. Read the comment docs.

@jreback jreback merged commit 6111f64 into pandas-dev:master Dec 18, 2018
@jreback
Copy link
Contributor

jreback commented Dec 18, 2018

thanks @topper-123

@topper-123 topper-123 deleted the CategoricalIndex_internals branch December 18, 2018 23:28
TomAugspurger pushed a commit to TomAugspurger/pandas that referenced this pull request Dec 20, 2018
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Categorical Categorical Data Type Internals Related to non-user accessible pandas implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants