-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Fix flake8 issues in doc/source/whatsnew/v0.17.*.rst #24340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! @datapythonista doc/source/whatsnew/v0.17.0.rst:177:22: E225 missing whitespace around operator The errors on line 177 are due to The next 3 errors are due to a comparison of a series vs None: What would be the best way to resolve these? |
we fixed them before with a |
also, please merge master and fix the conflicts when you update the PR |
@aqurilla do you have time to finish this PR? |
Hi @datapythonista yes, I was travelling and should be able to finish this by tomorrow |
@aqurilla do you have time to finish this? |
Codecov Report
@@ Coverage Diff @@
## master #24340 +/- ##
===========================================
+ Coverage 31.88% 92.28% +60.39%
===========================================
Files 166 162 -4
Lines 52413 51835 -578
===========================================
+ Hits 16714 47834 +31120
+ Misses 35699 4001 -31698
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24340 +/- ##
===========================================
+ Coverage 31.88% 92.32% +60.43%
===========================================
Files 166 166
Lines 52413 52440 +27
===========================================
+ Hits 16714 48416 +31702
+ Misses 35699 4024 -31675
Continue to review full report at Codecov.
|
Hi @datapythonista , please have a look, |
ping on green. |
@jreback, please have a look |
thanks @aqurilla |
git diff upstream/master -u -- "*.py" | flake8 --diff