BUG: Fix GSO values when writing latin-1 strLs #24337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @bashtage! Thanks for submitting the PR.
|
The size calculation of the string is incorrect when writing characters that have a different encoding in latin-1 and utf-8. The utf-8 size needs to be written in stead of the latin-1 size.
bashtage
force-pushed
the
fix-stata-strl-size-latin1
branch
from
2b5dc0a to
280f48b
Compare
|
lgtm. ping on green. |
Codecov Report
@@ Coverage Diff @@
## master #24337 +/- ##
=======================================
Coverage 92.28% 92.28%
=======================================
Files 162 162
Lines 51833 51833
=======================================
Hits 47833 47833
Misses 4000 4000
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #24337 +/- ##
=======================================
Coverage 92.28% 92.28%
=======================================
Files 162 162
Lines 51833 51833
=======================================
Hits 47833 47833
Misses 4000 4000
Continue to review full report at Codecov.
|
|
thanks @bashtage |
TomAugspurger
pushed a commit
to TomAugspurger/pandas
that referenced
this pull request
Dec 20, 2018
The size calculation of the string is incorrect when writing characters that have a different encoding in latin-1 and utf-8. The utf-8 size needs to be written in stead of the latin-1 size.
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
The size calculation of the string is incorrect when writing characters that have a different encoding in latin-1 and utf-8. The utf-8 size needs to be written in stead of the latin-1 size.
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
The size calculation of the string is incorrect when writing characters that have a different encoding in latin-1 and utf-8. The utf-8 size needs to be written in stead of the latin-1 size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The size calculation of the string is incorrect when writing characters
that have a different encoding in latin-1 and utf-8. The utf-8 size
needs to be written instead of the latin-1 size.
git diff upstream/master -u -- "*.py" | flake8 --diff