Skip to content

BUG: Fixed msgpack roundtrip with PeriodIndex #24335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 18, 2018

Conversation

TomAugspurger
Copy link
Contributor

Closes #24135

@pep8speaks
Copy link

Hello @TomAugspurger! Thanks for submitting the PR.

@TomAugspurger TomAugspurger added this to the 0.24.0 milestone Dec 18, 2018
@jreback
Copy link
Contributor

jreback commented Dec 18, 2018

lgtm.

@codecov
Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #24335 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24335      +/-   ##
==========================================
+ Coverage   92.28%   92.28%   +<.01%     
==========================================
  Files         162      162              
  Lines       51831    51833       +2     
==========================================
+ Hits        47830    47833       +3     
+ Misses       4001     4000       -1
Flag Coverage Δ
#multiple 90.68% <100%> (ø) ⬆️
#single 43% <66.66%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/io/packers.py 88.08% <100%> (ø) ⬆️
pandas/core/indexes/period.py 93.09% <100%> (+0.03%) ⬆️
pandas/util/testing.py 87.58% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 216986d...71a7f3d. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #24335 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24335      +/-   ##
==========================================
+ Coverage   92.28%   92.28%   +<.01%     
==========================================
  Files         162      162              
  Lines       51831    51833       +2     
==========================================
+ Hits        47830    47833       +3     
+ Misses       4001     4000       -1
Flag Coverage Δ
#multiple 90.68% <100%> (ø) ⬆️
#single 43% <66.66%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/io/packers.py 88.08% <100%> (ø) ⬆️
pandas/core/indexes/period.py 93.09% <100%> (+0.03%) ⬆️
pandas/util/testing.py 87.58% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 216986d...71a7f3d. Read the comment docs.

@jreback jreback merged commit 380eaf1 into pandas-dev:master Dec 18, 2018
@jreback
Copy link
Contributor

jreback commented Dec 18, 2018

thanks

TomAugspurger added a commit to TomAugspurger/pandas that referenced this pull request Dec 20, 2018
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants