DOC: Update compiler guidance for Windows #24331
Conversation
doc/source/contributing.rst
Outdated
| compiler installed. You don't need to do any of the ``./configure`` or ``make`` | ||
| steps; you only need to install the compiler. | ||
|
|
||
| For Windows developers, the following links may be helpful. | ||
|
|
||
| * **TL;DR** (Python 3.5+) install `Visual Studio 2017 <https://visualstudio.com/>`_, select | ||
| the **Python development workload** and the **Python native development tools** option |
There was a problem hiding this comment.
This feels a bit tricky, I'd explain this before saying that the following links may be helpful, and just keep the links here.
There was a problem hiding this comment.
Yeah, I wondered about that. But is it OK in principle?
Codecov Report
@@ Coverage Diff @@
## master #24331 +/- ##
==========================================
+ Coverage 92.28% 92.28% +<.01%
==========================================
Files 162 162
Lines 51831 51831
==========================================
+ Hits 47830 47831 +1
+ Misses 4001 4000 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24331 +/- ##
=======================================
Coverage 92.28% 92.28%
=======================================
Files 162 162
Lines 51831 51831
=======================================
Hits 47830 47830
Misses 4001 4001
Continue to review full report at Codecov.
|
| compiler installed. You don't need to do any of the ``./configure`` or ``make`` | ||
| steps; you only need to install the compiler. | ||
|
|
||
| For Windows developers, the following links may be helpful. | ||
| For Windows developers, when using Python 3.5 and later, it is sufficient to |
There was a problem hiding this comment.
This says 3.5 but the linked Python docs say 3.6 - is that a typo?
There was a problem hiding this comment.
this should be >= 3.5 i think
There was a problem hiding this comment.
The current version of the Python dev guide says 3.6+, but the MS Python engineering blog posts say 3.5+.
https://blogs.msdn.microsoft.com/pythonengineering/2017/03/07/python-support-in-vs2017/
https://blogs.msdn.microsoft.com/pythonengineering/2016/04/11/unable-to-find-vcvarsall-bat/
There was a problem hiding this comment.
So my understanding is that the VS 2015 toolchain is required for python 3.5 extensions, but VS 2017 supports multiple toolchains, and the "Python native development tools" installs both the 2015/2017 c++ toolchains, so works for python 3.5+
There was a problem hiding this comment.
That's correct, though IIRC Python 3.5 was never updated to automatically detect VS 2017, which is why the devguide refers to the newer version.
|
thanks @jamesmyatt |
... to make it a bit more encouraging.