Fixed PEP8 errors in doc/source/whatsnew/v0.15.* #24328

joybh98 · 2018-12-18T04:44:49Z

closes DOC: Fix flake8 issues in doc/source/whatsnew/v0.15.*.rst #24239
tests added / passed
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry
Fixed PEP8 errors in doc/source/whatsnew/v0.15.*, still can't get rid of line too long ( x >79) where x is the number of characters in line.

codecov · 2018-12-18T05:21:57Z

Codecov Report

Merging #24328 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #24328   +/-   ##
=======================================
  Coverage   92.28%   92.28%           
=======================================
  Files         162      162           
  Lines       51831    51831           
=======================================
  Hits        47830    47830           
  Misses       4001     4001

Flag	Coverage Δ
#multiple	`90.68% <ø> (ø)`	⬆️
#single	`43% <ø> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 216986d...6790593. Read the comment docs.

codecov · 2018-12-18T05:21:57Z

Codecov Report

Merging #24328 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #24328      +/-   ##
==========================================
- Coverage   92.38%   92.37%   -0.01%     
==========================================
  Files         166      166              
  Lines       52490    52471      -19     
==========================================
- Hits        48493    48471      -22     
- Misses       3997     4000       +3

Flag	Coverage Δ
#multiple	`90.8% <ø> (-0.02%)`	⬇️
#single	`43.05% <ø> (ø)`	⬆️

Impacted Files	Coverage Δ
pandas/core/internals/blocks.py	`94.21% <0%> (-0.33%)`	⬇️
pandas/core/indexes/datetimelike.py	`98.53% <0%> (-0.31%)`	⬇️
pandas/core/nanops.py	`94.36% <0%> (-0.19%)`	⬇️
pandas/core/arrays/categorical.py	`95.41% <0%> (-0.06%)`	⬇️
pandas/core/indexes/category.py	`98.61% <0%> (-0.04%)`	⬇️
pandas/core/internals/__init__.py	`100% <0%> (ø)`	⬆️
pandas/core/series.py	`93.56% <0%> (+0.02%)`	⬆️
pandas/core/internals/managers.py	`96.05% <0%> (+0.08%)`	⬆️
pandas/util/testing.py	`88.09% <0%> (+0.09%)`	⬆️
pandas/core/arrays/timedeltas.py	`88.18% <0%> (+0.19%)`	⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9175387...1b08068. Read the comment docs.

datapythonista

Looks good, thanks for the PR. Some comments in the code. Besides those:

Remove the test.parquet file you committed
Edit setup.cfg and remove the files you fixed from the list of exclude files of flake8-rst, so they start being validated
Edit the PR description and replace the #xxxxx by the issue you're closing

datapythonista · 2018-12-18T09:35:09Z

doc/source/whatsnew/v0.15.0.rst

@@ -7,10 +7,11 @@ v0.15.0 (October 18, 2014)

 .. ipython:: python
   :suppress:
-
+   
   from pandas import * # noqa F401, F403


we want to delete this whole block, that's one of the main points of the issue (see the description)

Just to be sure, you want me to remove the whole ipython block, am i right?

yes, you can see a similar case here: https://github.com/pandas-dev/pandas/pull/24236/files

datapythonista · 2018-12-18T09:35:40Z

doc/source/whatsnew/v0.15.0.rst

   from pandas import * # noqa F401, F403


+


this blank line is unnecessary, and it should break the validation

joybh98 · 2018-12-18T10:49:51Z

Okay,will fix all the problems.

jreback · 2018-12-18T13:37:58Z

pls merge master as well

datapythonista · 2018-12-18T13:54:26Z

@joybhallaa can you update in the description the issue you're closing

datapythonista · 2018-12-18T13:57:08Z

And when you fixed the conflict, looks like the 0.14.* files have been added back to the list of exclusions (check the diff in the PR). Can you remove them again.

Don't worry much, all these things usually happen to every first contributor. But we need everything in place to be able to merge this. :)

datapythonista · 2018-12-18T13:58:26Z

doc/source/whatsnew/v0.15.0.rst

@@ -77,7 +71,7 @@ For full docs, see the :ref:`categorical introduction <categorical>` and the
 .. ipython:: python
    :okwarning:

-    df = DataFrame({"id":[1,2,3,4,5,6], "raw_grade":['a', 'b', 'b', 'a', 'a', 'e']})
+    df = DataFrame({"id": [1, 2, 3, 4, 5, 6], "raw_grade": ['a', 'b', 'b', 'a', 'a', 'e']})


Is this the line too long you mention in the description? You can fix it by simply:

df = DataFrame({"id": [1, 2, 3, 4, 5, 6], "raw_grade": ['a', 'b', 'b', 'a', 'a', 'e']})

Or something similar, if you need to do it somewhere else too.

I tried this,but it led to more pep8 errors.

If the block is a code-block, you may need to add ... to the beginning of the continuation file. If you can't get it fixed yourself, leave it the way you think it's correct in the PR, so we can review it, and also see the errors in the CI.

joybh98 · 2018-12-20T02:40:29Z

@datapythonista , no need to comment, i know there are some errors left, but my machine is giving me some problems and I'll try to push the changes ASAP and will keep pushing them till all tests are passed.

joybh98 · 2018-12-21T05:30:24Z

@datapythonista , can't get rid of the remaining errors.

datapythonista

Besides the comments, can you restore the style.ipynb you deleted please

datapythonista · 2018-12-21T19:11:19Z

doc/source/whatsnew/v0.15.0.rst

@@ -836,7 +833,7 @@ Other notable API changes:

  .. code-block:: python


This indentation is wrong, should be at the top level. And this should be a .. code-block:: ipython (ipython instead of python.

See similar examples for the exact format.

datapythonista · 2018-12-21T19:15:45Z

doc/source/whatsnew/v0.15.1.rst

@@ -28,7 +22,7 @@ API changes

  .. ipython:: python

-     s = Series(date_range('20130101',periods=5,freq='D'))
+     s = pd.Series(pd.date_range('20130101', periods=5, freq='D'))
     s.iloc[2] = np.nan
     s



can you try to redefine df and ts before line 64 (can't comment there, as it's not edited in the PR)

I think they should be accessible from the previous block. You can also use # noqa F821 in the failing line, to stop the error from being raised.

datapythonista · 2018-12-25T00:05:53Z

You've got whitespaces in doc/source/whatsnew/v0.15.0.rst line 729, if you can remove them (and it can be a good idea to activate validation of pep8 errors in general in your editor, to avoid those).

Also, if you can merge master.

datapythonista

couple of comments, besides the problem with the whitespaces already mentioned

@joybhallaa do you have time to finish this?

datapythonista · 2018-12-30T23:49:26Z

doc/source/whatsnew/v0.15.0.rst


  Previously, assigning to ``None`` in numeric containers changed the
  dtype to object (or errored, depending on the call). It now uses
  ``NaN``:

-  .. ipython:: python
+  ..  ipython:: python


there should be only space between the .. and ipython. Here, and in all the cases that follow.

Yes, i will work on it ASAP.

datapythonista · 2018-12-30T23:50:53Z

doc/source/whatsnew/v0.15.0.rst

@@ -86,7 +81,8 @@ For full docs, see the :ref:`categorical introduction <categorical>` and the
    df["grade"].cat.categories = ["very good", "good", "very bad"]

    # Reorder the categories and simultaneously add the missing categories
-    df["grade"] = df["grade"].cat.set_categories(["very bad", "bad", "medium", "good", "very good"])
+    df["grade"] = df["grade"].cat.set_categories(
+      ["very bad", "bad", "medium", "good", "very good"])


better something like:

df["grade"] = df["grade"].cat.set_categories(["very bad", "bad", ...

jreback · 2019-01-01T16:32:18Z

can you merge master and update

jreback · 2019-01-02T12:52:41Z

you have an error:https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=6317

joybh98 · 2019-01-02T13:35:20Z

@datapythonista in v0.15.0,all pd,df are giving invalid syntax error,how can this be removed ?

jorisvandenbossche · 2019-01-02T15:38:48Z

Note there are still a bunch of failures in the doc build related to the clean-up (see eg https://travis-ci.org/pandas-dev/pandas/jobs/474277960)

datapythonista

Forget about the syntax errors, and any previous comment. Just fix the comments in this review, we'll merged the changes, and anything remaining will be addressed in a separate PR.

datapythonista · 2019-01-04T01:23:28Z

doc/source/whatsnew/v0.15.0.rst

     ts
     ts.tz_localize(None)

-     didx = DatetimeIndex(start='2014-08-01 09:00', freq='H', periods=10, tz='US/Eastern')
+     didx = pd.DatetimeIndex(


better:

didx = pd.DatetimeIndex(start='2014-08-01 09:00', ...

datapythonista · 2019-01-04T01:24:14Z

doc/source/whatsnew/v0.15.0.rst

-    df["grade"] = df["grade"].cat.set_categories(["very bad", "bad", "medium", "good", "very good"])
+    df["grade"] = df["grade"].cat.set_categories(["very bad",
+                                                  "bad", "medium",
+                                                 "good", "very good"]


this indentation needs to be at the same level as the previos. The ) in the next line should be at the end of this.

datapythonista · 2019-01-04T01:25:17Z

doc/source/whatsnew/v0.15.0.rst

-    data = dict([ (t, np.random.randint(100, size=n).astype(t))
-                    for t in dtypes])
-    df = DataFrame(data)
+    data = [(t, np.random.randint(100, size=n).astype(t))


data must be a dict, restore the previous

datapythonista · 2019-01-04T01:25:42Z

doc/source/whatsnew/v0.15.0.rst

     Out[7]:
     0    NaN
     1    1.0
     2    5.2
     dtype: float64

-     In [8]: pd.ewma(Series([1., None, 8.]), com=2., ignore_na=True)  # pre-0.15.0 behavior
+     In [8]: pd.ewma(pd.Series
+             ([1., None, 8.]), com=2., ignore_na=True)  # pre-0.15.0 behavior


restore the previous

datapythonista · 2019-01-04T01:25:52Z

doc/source/whatsnew/v0.15.0.rst

     Out[8]:
     0    1.0
     1    1.0
     2    5.2
     dtype: float64

-     In [9]: pd.ewma(Series([1., None, 8.]), com=2., ignore_na=False)  # new default
+     In[9]: pd.ewma(


restore the previous

datapythonista · 2019-01-04T01:28:51Z

doc/source/whatsnew/v0.15.1.rst

+  .. ipython:: python
+      :supress:
+      df = pd.DataFrame()
+      ts = pd.Timestamp()


remove this for now.

datapythonista · 2019-01-04T01:29:30Z

doc/source/whatsnew/v0.15.1.rst


+  .. code-block:: ipython


restore the original

datapythonista · 2019-01-04T01:29:54Z

doc/source/whatsnew/v0.15.1.rst

@@ -233,7 +231,8 @@ Enhancements

  .. ipython:: python

-     dfi = DataFrame(1,index=pd.MultiIndex.from_product([['a'],range(1000)]),columns=['A'])
+     dfi = pd.DataFrame(
+         1, index=pd.MultiIndex.from_product([['a'], range(1000)]), columns=['A'])


restore the original, fix the missing spaces only

datapythonista · 2019-01-04T01:30:11Z

doc/source/whatsnew/v0.15.2.rst

@@ -154,7 +148,7 @@ Other enhancements:
  .. code-block:: python

     from sqlalchemy.types import String
-     data.to_sql('data_dtype', engine, dtype={'Col_1': String})
+     data.to_sql('data_dtype', pd.engine, dtype={'Col_1': String})


restore the original

datapythonista · 2019-01-04T01:31:03Z

setup.cfg

+    doc/source/whatsnew/v0.16.1.rst
+    doc/source/whatsnew/v0.16.2.rst
+    doc/source/whatsnew/v0.17.0.rst
+    doc/source/whatsnew/v0.17.1.rst


restore the original, don't leave any changes to this file

jorisvandenbossche · 2019-01-04T16:10:52Z

doc/source/whatsnew/v0.15.0.rst


+This will return a Series, indexed like the existing Series. See the :ref:`docs <basics.dt_accessors>`
 .. ipython:: python


Can you revert this change? (there needs to be a blank line between the last sentence and .. ipython::)

jorisvandenbossche · 2019-01-04T16:12:02Z

doc/source/whatsnew/v0.15.0.rst

     Out[8]:
     0    1.0
     1    1.0
     2    5.2
     dtype: float64

-     In [9]: pd.ewma(Series([1., None, 8.]), com=2., ignore_na=False)  # new default
+     In[9]: pd.ewma(pd.Series([1., None, 8.]), com=2., ignore_na=False)  # new default
+


Can you revert this change?

jorisvandenbossche · 2019-01-04T16:12:35Z

doc/source/whatsnew/v0.15.0.rst

     except KeyError as e:
-        print("KeyError: " + str(e))


Can you add back this print statement?

jorisvandenbossche · 2019-01-04T16:13:27Z

doc/source/whatsnew/v0.15.0.rst

@@ -792,13 +791,13 @@ Other notable API changes:

  This is now the correct behavior

-  .. ipython:: python
+  ..  ipython:: python


revert the addition of the space here (sphinx is very sensitive to this kind of things ..)

jorisvandenbossche · 2019-01-04T16:13:34Z

doc/source/whatsnew/v0.15.0.rst

@@ -814,13 +813,13 @@ Other notable API changes:
  In prior versions this would drop the timezone, now it retains the timezone,
  but gives a column of ``object`` dtype:

-  .. ipython:: python
+  ..  ipython:: python


same here, and in a couple of ones below

jorisvandenbossche · 2019-01-04T16:13:54Z

doc/source/whatsnew/v0.15.0.rst

@@ -835,9 +834,9 @@ Other notable API changes:

 - ``SettingWithCopy`` raise/warnings (according to the option ``mode.chained_assignment``) will now be issued when setting a value on a sliced mixed-dtype DataFrame using chained-assignment. (:issue:`7845`, :issue:`7950`)

-  .. code-block:: python
+ ..  code-block:: ipython


remove space

jorisvandenbossche · 2019-01-04T16:14:29Z

doc/source/whatsnew/v0.15.1.rst

  on an ``errors`` argument, as well as a list of hard-coded country codes and
+- World Bank data requests now will warn/raise based


undo this switching of the lines

datapythonista · 2019-01-05T00:58:39Z

Closing this, it's been like 4 or 5 times that we request the same changes in the reviews. This is taking to much of our time to review.

Fixed PEP8 errors in doc/source/whatsnew/v0.15.*

6790593

datapythonista added Docs Clean labels Dec 18, 2018

datapythonista reviewed Dec 18, 2018

View reviewed changes

Fixed code review faults

065ec53

Resolved merge conflict of setup.cfg

ad389ec

datapythonista reviewed Dec 18, 2018

View reviewed changes

joybh98 added 2 commits December 19, 2018 23:38

Fixed some warnings

56af365

Resolved conflicts

f86ff74

joybh98 added 2 commits December 21, 2018 09:52

Fixed errors

1d62d9a

Merge remote-tracking branch 'upstream/master' into fix-doc-pep8

623c201

datapythonista reviewed Dec 21, 2018

View reviewed changes

joybh98 added 6 commits December 22, 2018 12:15

Restored style.ipynb

4ccd591

Fixed all undefined errors

870e0b7

Fixed all 0.15.1 errors

458ad38

Merge remote-tracking branch 'upstream/master' into fix-doc-pep8

0990ebc

Fixed 0.15.1 errors

d81927c

Merge remote-tracking branch 'upstream/master' into fix-doc-pep8

865a329

datapythonista requested changes Dec 30, 2018

View reviewed changes

datapythonista self-assigned this Dec 30, 2018

joybh98 added 2 commits January 2, 2019 10:03

Fixed pep-8 errors

dc8bb82

Resolved Merge Conflicts

879cf86

datapythonista requested changes Jan 4, 2019

View reviewed changes

joybh98 added 3 commits January 4, 2019 11:09

Changes pushed to v0.15

50a0699

Fixed setup.cfg

9ba2eab

Merge remote-tracking branch 'upstream/master' into fix-doc-pep8

1b08068

jorisvandenbossche reviewed Jan 4, 2019

View reviewed changes

datapythonista closed this Jan 5, 2019

		@@ -836,7 +833,7 @@ Other notable API changes:

		.. code-block:: python


		This will return a Series, indexed like the existing Series. See the :ref:`docs <basics.dt_accessors>`
		.. ipython:: python

		on an ``errors`` argument, as well as a list of hard-coded country codes and
		- World Bank data requests now will warn/raise based

Fixed PEP8 errors in doc/source/whatsnew/v0.15.* #24328

Fixed PEP8 errors in doc/source/whatsnew/v0.15.* #24328

Conversation

joybh98 commented Dec 18, 2018 • edited by datapythonista Loading

codecov bot commented Dec 18, 2018

Codecov Report

codecov bot commented Dec 18, 2018 • edited Loading

Codecov Report

datapythonista left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joybh98 commented Dec 18, 2018

jreback commented Dec 18, 2018

datapythonista commented Dec 18, 2018

datapythonista commented Dec 18, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joybh98 commented Dec 20, 2018

joybh98 commented Dec 21, 2018

datapythonista left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

datapythonista commented Dec 25, 2018

datapythonista left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jreback commented Jan 1, 2019

jreback commented Jan 2, 2019

joybh98 commented Jan 2, 2019

jorisvandenbossche commented Jan 2, 2019

datapythonista left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

datapythonista commented Jan 5, 2019

joybh98 commented Dec 18, 2018 •

edited by datapythonista

Loading

codecov bot commented Dec 18, 2018 •

edited

Loading