Skip to content

DOC: Not pushing the docs to github pages in PRs #24316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 17, 2018
Merged

DOC: Not pushing the docs to github pages in PRs #24316

merged 2 commits into from
Dec 17, 2018

Conversation

datapythonista
Copy link
Member

In #24292 we made the doc build fail when there is a failure. But in PR builds, pushing to github pages is expected to fail, so the build job is failing for every PR now. Pushing docs to github pages only for master builds in this PR (we still build the docs, to make sure it doesn't fail).

@datapythonista datapythonista added Docs CI Continuous Integration labels Dec 17, 2018
@codecov
Copy link

codecov bot commented Dec 17, 2018

Codecov Report

Merging #24316 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24316   +/-   ##
=======================================
  Coverage   92.28%   92.28%           
=======================================
  Files         162      162           
  Lines       51831    51831           
=======================================
  Hits        47831    47831           
  Misses       4000     4000
Flag Coverage Δ
#multiple 90.68% <ø> (ø) ⬆️
#single 43.01% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41780e5...9d33201. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 17, 2018

Codecov Report

Merging #24316 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24316   +/-   ##
=======================================
  Coverage   92.28%   92.28%           
=======================================
  Files         162      162           
  Lines       51831    51831           
=======================================
  Hits        47831    47831           
  Misses       4000     4000
Flag Coverage Δ
#multiple 90.68% <ø> (ø) ⬆️
#single 43.01% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41780e5...75f1434. Read the comment docs.

@jreback jreback added this to the 0.24.0 milestone Dec 17, 2018
@jreback jreback merged commit 49b51b8 into pandas-dev:master Dec 17, 2018
@jreback
Copy link
Contributor

jreback commented Dec 17, 2018

thanks

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants