Skip to content

DOC: Making the build fail if the doc build fails #24292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 16, 2018
Merged

DOC: Making the build fail if the doc build fails #24292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb8f940
DOC: Making the build fail if the doc build fails
datapythonista Dec 15, 2018
bc7d7a0
Merge remote-tracking branch 'upstream/master' into fail_doc_build
datapythonista Dec 16, 2018
8ad2ff1
Moving back doc build to allowed failures in travis
datapythonista Dec 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ before_script:
script:
- echo "script start"
- source activate pandas-dev
- ci/run_build_docs.sh
- ci/build_docs.sh
- ci/run_tests.sh

after_script:
Expand Down
2 changes: 2 additions & 0 deletions ci/build_docs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
#!/bin/bash

set -e

if [ "${TRAVIS_OS_NAME}" != "linux" ]; then
echo "not doing build_docs on non-linux"
exit 0
Expand Down
10 changes: 0 additions & 10 deletions ci/run_build_docs.sh
View file
Open in desktop

This file was deleted.

5 changes: 4 additions & 1 deletion doc/make.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,10 @@ def _run_os(*args):
# TODO check_call should be more safe, but it fails with
# exclude patterns, needs investigation
# subprocess.check_call(args, stderr=subprocess.STDOUT)
os.system(' '.join(args))
exit_status = os.system(' '.join(args))
if exit_status:
msg = 'Command "{}" finished with exit code {}'
raise RuntimeError(msg.format(' '.join(args), exit_status))

def _sphinx_build(self, kind):
"""Call sphinx to build documentation.
Expand Down