Skip to content

DOC: Add new required sphinx setting latex_elements #24291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2018
Merged

DOC: Add new required sphinx setting latex_elements #24291

merged 1 commit into from
Dec 15, 2018

Conversation

datapythonista
Copy link
Member

nbsphinx released a new version, 0.4.0, and it requires a sphinx setting that we don't have.

This is making the doc build fail, this PR adds it so the doc build works again.

CC: @jreback

@pep8speaks
Copy link

Hello @datapythonista! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Dec 15, 2018

Codecov Report

Merging #24291 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24291   +/-   ##
=======================================
  Coverage   92.22%   92.22%           
=======================================
  Files         162      162           
  Lines       51824    51824           
=======================================
  Hits        47795    47795           
  Misses       4029     4029
Flag Coverage Δ
#multiple 90.62% <ø> (ø) ⬆️
#single 43.01% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b0fa8e...1399593. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 15, 2018

Codecov Report

Merging #24291 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24291   +/-   ##
=======================================
  Coverage   92.22%   92.22%           
=======================================
  Files         162      162           
  Lines       51824    51824           
=======================================
  Hits        47795    47795           
  Misses       4029     4029
Flag Coverage Δ
#multiple 90.62% <ø> (ø) ⬆️
#single 43.01% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b0fa8e...1399593. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Dec 15, 2018

maybe better to just pin the version until we know ifbit works ok?

@datapythonista
Copy link
Member Author

As you prefer, but I think it was just that our conf.py was generated so much time ago, that nbsphinx was assuming every project would have a setting that sphinx added enough time ago.

I think it's just a normal update, nothing buggy on it. In any case, won't be able to create the PR for pinning the version myself until Sunday probably. If that's preferred, someone else should do it.

@jreback jreback added this to the 0.24.0 milestone Dec 15, 2018
@jreback jreback merged commit 5e0362e into pandas-dev:master Dec 15, 2018
@jreback
Copy link
Contributor

jreback commented Dec 15, 2018

thanks!

have a look at built docs when they r done.

@datapythonista
Copy link
Member Author

The docs look good. I think the only page that could be affected by the nbsphinx update, is this one as it's the only .ipynb: https://pandas-docs.github.io/pandas-docs-travis/style.html

And it looks good. Also checked the ipython directive rendering in other pages, and nothing seems to be changed.

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants